490121 - Drag & drop scrolling in places menus needs to be more responsive

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ria Klaassen (not reading all bugmail)]

STR:

- Have a folder on your toolbar with more items in it then you can see
- Drag the favicon from the locationbar to this folder, wait until it opens, drag it onto the triangle on the bottom of the menu

Actual result: it scrolls very slowly
Desired result: it scrolls with normal speed

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3051d82cb64f&tochange=94cb97a93667

Comment 1

[Ria Klaassen (not reading all bugmail)]

The scroll speed is two items per second.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Not in latest nightly Shiretoko.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Seems to be one of the checkins done at Fri Apr 10 01:25:07 2009 -0700.
Performance is also bad on a fast system.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

There are two ways to address this. The first one is to expand the fix for bug 487946 to all scrollByIndex calls, instead of doing it only in for DOMMouseScroll, as mentioned in bug 487946 comment 4. The second way is to disable smooth scrolling for this specific scrollByIndex call.

This patch does both, because smooth scrolling still feels suboptimal here even with the first solution implemented.

Comment 5

[Neil Deakin]

Comment on attachment 376319 [details] [diff] [review]
patch

OK. I wonder if it would be better to just have a 'smoothscroll' attribute to enable or disable it.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> (From update of attachment 376319 [details] [diff] [review])
> OK. I wonder if it would be better to just have a 'smoothscroll' attribute to
> enable or disable it.

We do have that, but it's not clear that smooth scrolling should be disabled altogether in menus.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/2d43b417d33f

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv