Closed Bug 490150 Opened 15 years ago Closed 15 years ago

report what the exception was when command updating failed

Categories

(Toolkit Graveyard :: Error Console, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file)

Attached patch proposed fixSplinter Review
(Sorry, couldn't find a better component.)

In globalOverlay.js when a command updating fails, all we do is dump that it happend in the console. This makes it harder than necessary to find out where you messed up...

Would be way better if the exception was also shown, and I suggest using Components.utils.reportError instead of dump.
Attachment #374606 - Flags: superreview?(gavin.sharp)
Attachment #374606 - Flags: review?(gavin.sharp)
Attachment #374606 - Flags: superreview?(gavin.sharp)
Attachment #374606 - Flags: review?(gavin.sharp)
Attachment #374606 - Flags: review+
changeset:   27860:daefd30072a6
http://hg.mozilla.org/mozilla-central/rev/daefd30072a6

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Flags: in-testsuite-
Flags: in-litmus-
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: