Closed Bug 490152 Opened 15 years ago Closed 14 years ago

test_framerecursion.html | Error thrown during test: onLoad is not defined - got 0, expected 1

Categories

(Toolkit Graveyard :: Microformats, defect)

Product:
Toolkit Graveyard
Component:
Microformats
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: graydon, Assigned: ehsan.akhgari)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

For check-in
3.23 KB, patch
Details | Diff | Splinter Review 
Got a random orange yesterday:

*** 75183 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/microformats/tests/test_framerecursion.html | Error thrown during test: onLoad is not defined - got 0, expected 1

Build log is: WINNT 5.2 tracemonkey unit test on 2009/04/24 23:17:03

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1240640223.1240647861.15222.gz

Vanished with cycling the tester.
Whiteboard: [orange]
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1251636291.1251644993.23307.gz
Linux mozilla-central unit test on 2009/08/30 05:44:51
Actually the above failure says "onLoad is not defined, which is very strange since it's clearly defined in the page script...
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1257866178.1257866986.20292.gz
Linux mozilla-central debug test mochitests-5/5 on 2009/11/10 07:16:18
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267450792.1267452084.9815.gz
WINNT 5.2 mozilla-central debug test mochitests-5/5 on 2010/03/01 05:39:52
s: win32-slave23
What about moving the onLoad function into a script tag in the head? Maybe it's a parser timing issue.
Attached patch Patch (v1) (obsolete) — — Splinter Review 
Move the script block before the iframe.  Should be a trivial review.
Assignee: mozilla → ehsan
Status: NEW → ASSIGNED
Attachment #492258 - Flags: review?(gavin.sharp)
Comment on attachment 492258 [details] [diff] [review]
Patch (v1)

>diff --git a/toolkit/components/microformats/tests/test_framerecursion.html b/toolkit/components/microformats/tests/test_framerecursion.html

>-  <pre id="test">

I don't think you actually want to remove this? IIRC it's used by the harness to print out results...
Attachment #492258 - Flags: review?(gavin.sharp) → review+
Attached patch For check-in — — Splinter Review 

        Attachment #492258 -
        Attachment is obsolete: true

    
  
Whiteboard: [orange] → [orange][needs landing]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/8cde8889726d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange][needs landing] → [orange]
Target Milestone: --- → mozilla2.0b8
Whiteboard: [orange]

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: