490173 - Removing display:-moz-popup doesn't make children appear

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Comment 1

[Jesse Ruderman]

Attachment: reference

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

What happens here is that the frame is suppressed because there is no root popupgroup... but then when we change the style and go to MaybeRecreateFramesForContent we have no frame and no undisplayed entry, so we don't do anything.  Since a display change can cause us to in fact need a reconstruct, we need an undisplayed entry.

I added the undisplayed setting in the suppress case right above that just in case; I don't see that it can harm anything, and if some of the SVG situations that can cause suppression might depend on style data, it'd help those cases.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Oh, I suppose I should also write a testcase for the colgroup/column case...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: With a reftest for that too

That testcase fails without the patch, passes with.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 374995 [details] [diff] [review]
With a reftest for that too

r+sr=dbaron

Comment 6

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6aa0cb2a52fb

Comment 7

[Boris Zbarsky [:bzbarsky]]

Er, and somehow I managed to typo the reftest.list lines...  Fixed with http://hg.mozilla.org/mozilla-central/rev/c61fc3216701