Closed Bug 490195 Opened 15 years ago Closed 15 years ago

Search field in "Get Add-ons" panel is bad aligned

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Version:
1.9.1 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: whimboo, Assigned: mossop)

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy] [polish-visual][polish-p2])

Attachments

(5 files, 1 obsolete file)

Bad aligned search field
18.37 KB, image/jpeg
Details
screenshot with patch
64.03 KB, image/png
Details
vertical margin
17.24 KB, image/jpeg
Details
patch rev 2
1.13 KB, patch
dao
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
1px offset on Linux
45.40 KB, image/jpeg
Details 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 (.NET CLR 3.5.30729)

The search field inside the "Get Add-ons" panel of the Add-ons Manager is bad aligned. See the attached screenshot. It looks fine on OS X. Haven't tested on Linux yet.
Attached patch patch rev 1 (obsolete) — — Splinter Review 
The search box has margin, the richlistbox doesn't.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #376412 - Flags: review?(dao)
Attached image screenshot with patch — 

    
    

    
  
Dave, what about the vertical margins? Shouldn't we use the same value on both sides (top, down) of the search field? The empty space on top is unused space.

    
    

    
  
(In reply to comment #3)
> Dave, what about the vertical margins? Shouldn't we use the same value on both
> sides (top, down) of the search field? The empty space on top is unused space.

I'm not sure what you're saying here, but I'm not particularly bothered with tinkering with the UI right now as the hope is to replace it in 3.6. I just want to close this out as it stands out as wrong right now.

    
    

    
  

      
      
      
      

        Attached image
          
        vertical margin
        — 
      

    


  
See this screenshot and the markers.

    
    

    
  
I agree that the horizontal misalignment is more jarring and care less about the vertical alignment. gnomestripe is missing in the patch, though.

    
  

        Attachment #376412 -
        Flags: review?(dao)

    
    

    
  
Comment on attachment 376412 [details] [diff] [review]
patch rev 1

See previous comment -- gnomestripe needs the same fix.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch rev 2
        — 
          — Splinter Review
      

    


  

        Attachment #376412 -
        Attachment is obsolete: true

        Attachment #377376 -
        Flags: review?(dao)

    
    

    
  
Comment on attachment 377376 [details] [diff] [review]
patch rev 2

nit: 0 doesn't need a unit

        Attachment #377376 -
        Flags: review?(dao) → review+

    
    

    
  
Landed: http://hg.mozilla.org/mozilla-central/rev/abfb6aa0e08a
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1

    
    

    
  
Comment on attachment 377376 [details] [diff] [review]
patch rev 2

trivial fix, should land on branch.

        Attachment #377376 -
        Flags: approval1.9.1?

    
  
Component: Add-ons Manager → Themes
QA Contact: add-ons.manager → themes

    
    

    
  
With Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090515 Minefield/3.6a1pre ID:20090515031832 the search box is still placed 1px to the right. Is that expected?
Status: RESOLVED → VERIFIED
OS: Windows XP → All

    
    

    
  
Nope. Got a screenshot?

    
    

    
  

      
      
      
      

        Attached image
          
        1px offset on Linux
        — 
      

    


  
Lets reopen the bug for the remaining fix.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
    

    
  
You're seeing a soft widget border.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED

    
  
Keywords: fixed1.9.1

    
    

    
  
Oops!
Keywords: fixed1.9.1

    
    

    
  
Oh, thanks for the hint. That's true. Marking verified again.
Status: RESOLVED → VERIFIED
Keywords: polish
Whiteboard: [polish-easy] [polish-visual]

        Attachment #377376 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Doesn't look like I'll have the opportunity to land this so if someone else could get it on branch before freeze that'd be great.
Keywords: checkin-needed

    
    

    
  
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090521 Shiretoko/3.5pre. Will check Linux next.

    
    

    
  
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1pre) Gecko/20090521 Shiretoko/3.5pre. Adding the verified keyword.
Keywords: fixed1.9.1 → verified1.9.1

    
    

    
  
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p2]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: