490204 - It needs to be possible to disable MMGC_MEMORY_INFO in DEBUG builds

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Lars T Hansen]

Attachment: Patch v1

A simple adjustment is all it takes: a couple of calls need to be #ifdef'd.

Comment 1

[Rishit Shah]

review+

Comment 2

[Lars T Hansen]

redux changeset:   1814:00071f9b1b97

Comment 3

[Lars T Hansen]

Comment on attachment 374655 [details] [diff] [review]
Patch v1

It still does not compile when MEMORY_INFO is turned off in debug mode (on Mac) and this fix did not compile on Windows.  There seems to be copious confusion about whether MEMORY_PROFILER requires MEMORY_INFO, and about who owns various global definitions used throughout the code for debugging.

Comment 4

[Rishit Shah]

I had asked Tommy the same question last week and his response was that MMGC_MEMORY_INFO and MMGC_MEMORY_PROFILER are independent of each other.

I will remove the existing dependencies of these 2 features.

By ownership of global definitions you mean the feature or their supporting methods?

Comment 5

[Rishit Shah]

Attachment: [v2] patch

Comment 6

[Lars T Hansen]

(In reply to comment #4)
> I had asked Tommy the same question last week and his response was that
> MMGC_MEMORY_INFO and MMGC_MEMORY_PROFILER are independent of each other.

OK, let that be recorded somewhere...

> I will remove the existing dependencies of these 2 features.
> 
> By ownership of global definitions you mean the feature or their supporting
> methods?

By ownership I was referring to MMGC_MEMORY_INFO or MMGC_MEMORY_PROFILER (or some other entity).

Comment 7

[Tommy Reilly]

I vote we rename MMGC_MEMORY_INFO MMGC_MEMORY_GUARD_EDGES_AND_SCRIBBLE or something that reflects what it actually does.

Comment 8

[Rishit Shah]

changeset 1835	54ab974aaae4