490249 - Use one feed icon instead of three

Status: VERIFIED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Tyler Downer [He/Him]]

Attachment: wip 1

In feeds, the audiofeedicon, videofeedicon, and feedicon png's are all exactly the same. It doesn't make sens to put those extra images, their css, and build them when we could just declare feedicon for everything.

This patch combines feedBackground, .videoPodcastBackground, and .videoPodcastBackground with the same css properties, takes out the old stuff, removes the images, and deletes them from jar.mn.

The only reasons I can see keeping separate images is if a bug appears when we try to use the same image for these different things. I really don't think that would happen, but it is possible. Or, if we decide to make different icons for video, audio, and feed, then we will need to keep separate styles for each.

This patch is a WIP, if we decide to go ahead on this, I still need to take out the 16X16's and aero, and linux and mac styles as well. This just covers XP to get the idea.

This benefits us by cleaning out some stuff from the feed css, and taking out these duplicate images, saving size and cleaning out this portion of the tree a bit, making it a bit easier to work with. Also, if we make a change to the feed icons, we just have to change one, instead of three.

Comment 1

[Tyler Downer [He/Him]]

Attachment: wip 2

Alright, second wip. This one has all the duplicate icons removed, along with their jar.mn lines and css. This covers win, gnome and pin.
I could not find the 16px and aero files in a css file, assuming that is automatic somehow? Not real sure here.

While in here, noticed a funny thing, feed-icons.png, in pin and gnome, in the root browser directory, while win has it in browser/feeds. Where should it go? Figured while I am in here might as well move it to the correct location. browser/theme makes more sense, but it doesn't matter much.

Let me know how this looks. When I get back in two weeks, will run through and clean it up and hopefully get something ready for a real review.

Asking for review so I can see if I am going in the right direction.

Comment 2

[Tyler Downer [He/Him]]

Need to actually remove the images in the next patch, but you can see what is being removed from the jar.mn files.

Comment 3

[Tyler Downer [He/Him]]

Looking around, these images were added in bug 400064, and bug 400061#c18 says that these will be replaced with better, more specific icons when ready, so making this WONT.