Closed Bug 490282 Opened 13 years ago Closed 13 years ago

Trigger choice of customization sheet from a pref instead of a build-time widget ifdef

Categories

(Thunderbird :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
The other half of stealing the benefits from SeaMonkey's deathmarch to customizable toolbars, following on from bug 489047 - by making the choice between using a dialog and the panel pretending to be a sheet we use on OS X based on a pref instead of a build-time MOZ_WIDGET_TOOLKIT = cocoa ifdef, we can not only clean up a bunch of defines, but we can also make it possible for people without a Mac to see at least approximately what they are doing to the sheet-panel without needing to make a ton of changes and rebuild each time.

The cost, an unneeded DTD and a panel containing a hidden iframe that won't ever have a src attribute, seems pretty small.
Flags: in-testsuite-
Attachment #374732 - Flags: review?(bugzilla)
Comment on attachment 374732 [details] [diff] [review]
Fix

r=Standard8.

Bonus points if you work out what happened to our icons on the customise sheet on the main mail window.
Attachment #374732 - Flags: review?(bugzilla) → review+
Huh, you're missing icons? All, or just some? I think I've got a full load myself, though "what happened" would have to be me screwing up stylesheet overlays in bug 489047, or maybe ordering from the smime over-inclusion thing.
http://hg.mozilla.org/comm-central/rev/bc4a5c45d3ac
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.