490365 - Corruption of start window

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: screenshot

Memory allocation failure occurs at 
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/src/gfxImageSurface.cpp#80

I guess jemalloc build is broken.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

not surprisingly, it is huge_malloc that is failing

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: A patch

I found a mistake in configure.in.

The first part of this fix is not concerned to this issue but I think it should be fixed.

I am building with this fix now.

Comment 3

[Stuart Parmenter]

2nd part looks right not sure about the first

Comment 4

[Hiroyuki Ikezoe (:hiro)]

The first part was confusable to me.

I confirmed the patch fixes this issue now.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Because MOZ_MEMORY_WINCE6 is being defined, JEMALLOC_USES_MAP_ALIGN isn't getting defined so we don't call pages_map_align from huge_malloc.  This results in huge_malloc failing.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

By the way, the comment in jemalloc.c should also be fixed.

--- a/memory/jemalloc/jemalloc.c	Tue Apr 28 01:37:02 2009 +0200
+++ b/memory/jemalloc/jemalloc.c	Tue Apr 28 13:08:14 2009 +0900
@@ -6118,17 +6118,17 @@ malloc_shutdown()
  * zone infrastructure.
  */
 #ifdef MOZ_MEMORY_DARWIN
 #  define ZONE_INLINE	inline
 #else
 #  define ZONE_INLINE
 #endif
 
-/* Mangle standard interfaces on Darwin and Windows CE, 
+/* Mangle standard interfaces on Darwin, 
    in order to avoid linking problems. */
 #if defined(MOZ_MEMORY_DARWIN)
 #define	malloc(a)	moz_malloc(a)
 #define	valloc(a)	moz_valloc(a)
 #define	calloc(a, b)	moz_calloc(a, b)
 #define	realloc(a, b)	moz_realloc(a, b)
 #define	free(a)		moz_free(a)

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/dc2dc621fd34