Closed
Bug 490365
Opened 15 years ago
Closed 15 years ago
Corruption of start window
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: hiro, Assigned: hiro)
Details
(Keywords: mobile)
Attachments
(2 files)
18.47 KB,
image/png
|
Details | |
1.29 KB,
patch
|
vlad
:
review+
vlad
:
superreview+
|
Details | Diff | Splinter Review |
Memory allocation failure occurs at http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/src/gfxImageSurface.cpp#80 I guess jemalloc build is broken.
Updated•15 years ago
|
Component: General → jemalloc
Product: Fennec → Core
QA Contact: general → jemalloc
Comment 1•15 years ago
|
||
not surprisingly, it is huge_malloc that is failing
Assignee | ||
Comment 2•15 years ago
|
||
I found a mistake in configure.in. The first part of this fix is not concerned to this issue but I think it should be fixed. I am building with this fix now.
Assignee: nobody → ikezoe
Comment 3•15 years ago
|
||
2nd part looks right not sure about the first
Assignee | ||
Comment 4•15 years ago
|
||
The first part was confusable to me. I confirmed the patch fixes this issue now.
Comment 5•15 years ago
|
||
Because MOZ_MEMORY_WINCE6 is being defined, JEMALLOC_USES_MAP_ALIGN isn't getting defined so we don't call pages_map_align from huge_malloc. This results in huge_malloc failing.
Assignee | ||
Updated•15 years ago
|
Attachment #374834 -
Flags: superreview?(pavlov)
Attachment #374834 -
Flags: review?(vladimir)
Assignee | ||
Comment 6•15 years ago
|
||
By the way, the comment in jemalloc.c should also be fixed. --- a/memory/jemalloc/jemalloc.c Tue Apr 28 01:37:02 2009 +0200 +++ b/memory/jemalloc/jemalloc.c Tue Apr 28 13:08:14 2009 +0900 @@ -6118,17 +6118,17 @@ malloc_shutdown() * zone infrastructure. */ #ifdef MOZ_MEMORY_DARWIN # define ZONE_INLINE inline #else # define ZONE_INLINE #endif -/* Mangle standard interfaces on Darwin and Windows CE, +/* Mangle standard interfaces on Darwin, in order to avoid linking problems. */ #if defined(MOZ_MEMORY_DARWIN) #define malloc(a) moz_malloc(a) #define valloc(a) moz_valloc(a) #define calloc(a, b) moz_calloc(a, b) #define realloc(a, b) moz_realloc(a, b) #define free(a) moz_free(a)
Comment 7•15 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/dc2dc621fd34
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #374834 -
Flags: superreview?(pavlov)
Attachment #374834 -
Flags: superreview+
Attachment #374834 -
Flags: review?(vladimir)
Attachment #374834 -
Flags: review+
Updated•14 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•