490489 - Add "Next" and "Previous" links to pagination

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[krupa raj[:krupa]]

Currently pagination has "<<" and ">>" to navigate to the next and previous page.

It is more user-friendly to specify "<<-Previous" and "Next->>"

Current: <<1 2 3...n >>

Expected: Previous 1 2 3 ...n Next OR <<-Previous 1 2 3...n Next->>

Comment 1

[David Tenser [:djst]]

I'd make that "<< Previous" and "Next >>" (replace the - with space)

Comment 2

[Paul Craciunoiu [:paulc]]

I'd like to make clear which places we'd like to see this happen. There are quite a few templates that use pagination.

Krupa, could you maybe walk through the site and point out where this pagination occurs?
E.g. the .php files or URLs

Comment 3

[krupa raj[:krupa]]

Search results dont have "<< Previous" and "Next >>" links.

For eg: https://support-stage.mozilla.org/tiki-newsearch.php?where=f&locale=en-US&q=browser&sa=

Forum topics and knowledge base article listings have these links.

Comment 4

[Paul Craciunoiu [:paulc]]

I see we use "<< Prev" for previous on
http://support.mozilla.com/tiki-view_forum.php?locale=en-US&forumId=1&comments_threshold=0&thread_sort_mode=lastPost_desc&comments_per_page=20&time_control=1209600&poster=&issue_solved=&reply_state=&comments_offset=20

Should we use the same on search?

Comment 6

[Paul Craciunoiu [:paulc]]

Attachment: Patch: proposed fix, v1

This patch does several things:

* change the hardcoded "10" from results per page in make_link_pages to $length (should have been used instead)
* adds "<< Previous" and "Next >>" links when there is a next/previous page
* updates CSS spacing, as with word-spacing: 10px the "<<" and "Previous" (and "Next" and ">>", respectively) are too far apart. Padding achieves the same result and makes more sense
* updates the make_links_pages function to output a <span> with class "current_page" for the current page, which is how we had it in our search results previously and gives better control over the current page element (previously was just plain text directly into the HTML)

I know this seems long but it should be easy to test :)

Comment 7

[Paul Craciunoiu [:paulc]]

Comment on attachment 376792 [details] [diff] [review]
Patch: proposed fix, v1

Eric, by all means, if you have time...

Comment 8

[Paul Craciunoiu [:paulc]]

r25737 / r25739

Comment 9

[krupa raj[:krupa]]

Paul,I dont see the Next and Prev links in search-

http://support-stage.mozilla.org/tiki-newsearch.php?locale=en&q=browser&where=all&l=en&filter_lang=0&author=&filter_author=0&en_too=&type=0&answered=0&lastmodif=0&offset=40

Am I missing something?

Comment 10

[Paul Craciunoiu [:paulc]]

I think stage and production have been rolled back to 1.0.2, were they rolled back after that? I don't they were. The links should definitely be there.

Laura?

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Paul, please close this.  Bug 493674 is now fixed; thanks!

Comment 12

[Paul Craciunoiu [:paulc]]

Roger that. Closed as per bug 493674.

Comment 13

[krupa raj[:krupa]]

Chevrons need some layout love.

screenshot: http://screencast.com/t/qFEj1gh2

URL: http://support-stage.mozilla.org/tiki-newsearch.php?locale=en&q=browser&where=all&l=en&filter_lang=1&author=&filter_author=0&en_too=1&type=0&answered=0&lastmodif=0&offset=60

Comment 14

[krupa raj[:krupa]]

To be clear I reopened the bug coz the chevron wraps to the next line.

Comment 15

[Paul Craciunoiu [:paulc]]

Cool. Thanks Krupa, will do some CSSing

Comment 16

[Paul Craciunoiu [:paulc]]

r25987 / r25988
Less padding. It should fit now :)

Comment 17

[krupa raj[:krupa]]

Filed a regression  -Bug 494086

Marking this as verified.

Comment 18

[Paul Craciunoiu [:paulc]]

Comment on attachment 376792 [details] [diff] [review]
Patch: proposed fix, v1

Just going through my r? list