490576 - Layout issues with long or many add-ons' author names

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

I think Les either mentioned these both outright or alluded to them in https://bugzilla.mozilla.org/show_bug.cgi?id=475605#c50:

In the following screenshot, look at:

[1] Firefox Universal Uploader
* Description text runs into the "Add to Firefox" (This add-on is for older versions of Firefox) button.

[2] PDF Download
* Author names run into the add-on icon

(There's a third issue, too, that the description text isn't using ellipses to truncate, but that's a separate bug.)

Comment 1

[Ryan Doherty (:rdoherty)]

Attachment: Truncation patch

Patch that truncates just about everything.

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 375094 [details] [diff] [review]
Truncation patch

In the "top rated" column, I get lots of these:

<b>Notice</b>:  Undefined index:  Addon in <b>/Users/fred/dev/amo/site/app/views/addons/category_landing.thtml</b> on line <b>191</b><br />

Comment 3

[Ryan Doherty (:rdoherty)]

Attachment: Truncation patch

Patch with fixed errors.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 375101 [details] [diff] [review]
Truncation patch

That works well.

Comment 5

[Ryan Doherty (:rdoherty)]

r25073

For QA:
Truncation added to add-on names and summaries (28 and 70 characters, respectively). Truncation function chops off at character limit, then traverses backwards to the closest space and adds the ellipsis there.

Add-on authors limited to 2.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:4