Closed
Bug 490581
Opened 15 years ago
Closed 15 years ago
All builders should TinderboxPrint their names
Categories
(Mozilla Messaging Graveyard :: Release Engineering, defect)
Mozilla Messaging Graveyard
Release Engineering
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gozer, Unassigned)
Details
Attachments
(2 files)
456 bytes,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
791 bytes,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
When a single host is busted, it would make it very easy to spot if it always TinderboxPrint'ed it's hostname, instead of just logging it. Something like host: momo-vm-xx
Reporter | ||
Comment 1•15 years ago
|
||
Attachment #377718 -
Flags: review?(bhearsum)
Comment 2•15 years ago
|
||
Comment on attachment 377718 [details] [diff] [review] [checked in] Tinderbox the slavename Yeah, this seems like a good idea.
Attachment #377718 -
Flags: review?(bhearsum) → review+
Comment 3•15 years ago
|
||
Comment on attachment 377718 [details] [diff] [review] [checked in] Tinderbox the slavename changeset: 294:e37c0b140d3a
Updated•15 years ago
|
Attachment #377718 -
Attachment description: Tinderbox the slavename → [checked in] Tinderbox the slavename
Comment 4•15 years ago
|
||
I noticed that it doesn't work on Windows because we end up with quotes around the whole line. This patch at least reduces the quoted part to be what's after the TinderboxPrint: so that it actually is displayed on Windows columns as well.
Attachment #378764 -
Flags: review?(bhearsum)
Comment 5•15 years ago
|
||
Comment on attachment 378764 [details] [diff] [review] [checked in] make it work on Windows as well thanks for catching this KaiRo
Attachment #378764 -
Flags: review?(bhearsum) → review+
Comment 6•15 years ago
|
||
Comment on attachment 378764 [details] [diff] [review] [checked in] make it work on Windows as well Pushed as http://hg.mozilla.org/build/buildbotcustom/rev/b9f1bae782f4 - I'll leave it up to gozer to mark the bug fixed :)
Attachment #378764 -
Attachment description: make it work on Windows as well → [checked in] make it work on Windows as well
Reporter | ||
Comment 7•15 years ago
|
||
(In reply to comment #6) > (From update of attachment 378764 [details] [diff] [review]) > Pushed as http://hg.mozilla.org/build/buildbotcustom/rev/b9f1bae782f4 - I'll > leave it up to gozer to mark the bug fixed :) Thanks for the troubleshooting KaiRo. Works great!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•