490669 - Padding changes on HTML select between 3.1b3 and 3.5b4

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 ID:20090423191946

Is this padding change intended ? It makes the text feel more cramped, looks like 1 less pixel top and bottom. The screenshot is a side-by-side with the colour reddened for the 3.5b4 side.

Comment 1

[Markus Stange [:mstange]]

Attachment: small sized native dropdown buttons in CSSEdit

Yes, it's intended. It might feel more cramped, but it's closer to the look of native dropdown buttons (which is what we're trying to achieve). See for example the dropdowns in CSSEdit in the attached screenshot. It's also what Safari does.
IOW, the larger size was simply the wrong size for that specific text size.

And there's another reason: Apple doesn't let us draw these controls with arbitrary sizes (see also bug 476277). The bigger size in the left part of your screenshot was only available on 10.4; on 10.5 we were downscaling a larger size button. This looked bad, so we've decided to only use the three "natural" sizes. And in this case, snapping to the smaller size looks better than snapping to the larger size.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

--> INVALID then, and time to retrain my brain.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

This is actually one of the subtle things that made Safari seem slightly more streamlined, and Firefox not as much.  Crazy widget psychology :)