remove acceptance test references to [object null]

VERIFIED FIXED

Status

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: dschaffe, Assigned: dschaffe)

Tracking

unspecified
x86
Mac OS X
Bug Flags:
flashplayer-triage +

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
since bug fix 483315 in 1788 (MethodEnv points to ScopeChain points to ScopeChain rather than VTable) no more [object null] appears as Function objects toString.  we should remove the test references.  in several places we test toString().indexOf("[object Function") == 0 or toString()=='[object null]'  we can remove the 2nd condition to regression test.
Flags: flashplayer-triage+
(Assignee)

Comment 1

9 years ago
Created attachment 375080 [details] [diff] [review]
patch

also I'll run a sandbox build to make sure works on all platforms.
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED
Attachment #375080 - Flags: review?(brbaker)

Updated

9 years ago
Attachment #375080 - Flags: review?(brbaker) → review+

Comment 2

9 years ago
Comment on attachment 375080 [details] [diff] [review]
patch

+, but there are still a couple of references to Function- and object null in the test suite:

acceptance\ecma3\FunctionObjects\e15_3_2_1_1_rt.as(106)

ecma3\FunctionObjects\e15_3_2_1_2_rt.as(71):
(Assignee)

Comment 3

9 years ago
fixed above 2 references, submitted in 1819 : 4013f0557b21
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

9 years ago
closing bug by marking verified/fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.