Closed
Bug 490698
Opened 15 years ago
Closed 15 years ago
remove acceptance test references to [object null]
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dschaffe, Assigned: dschaffe)
Details
Attachments
(1 file)
|
3.87 KB,
patch
|
brbaker
:
review+
|
Details | Diff | Splinter Review |
since bug fix 483315 in 1788 (MethodEnv points to ScopeChain points to ScopeChain rather than VTable) no more [object null] appears as Function objects toString. we should remove the test references. in several places we test toString().indexOf("[object Function") == 0 or toString()=='[object null]' we can remove the 2nd condition to regression test.Flags: flashplayer-triage+
|
Assignee | |
Comment 1•15 years ago
|
||
also I'll run a sandbox build to make sure works on all platforms.
|
||
Updated•15 years ago
|
Attachment #375080 -
Flags: review?(brbaker) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 375080 [details] [diff] [review] patch +, but there are still a couple of references to Function- and object null in the test suite: acceptance\ecma3\FunctionObjects\e15_3_2_1_1_rt.as(106) ecma3\FunctionObjects\e15_3_2_1_2_rt.as(71):
|
|
Assignee | |
Comment 3•15 years ago
|
||
fixed above 2 references, submitted in 1819 : 4013f0557b21
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•