490738 - [Extension] Polish up login window

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

Attachment: mockup

Please see the attached mockup. A few changes:
- changed "username" to "e-mail address" - this is already reflected in l10n
- Added a login form header part. This is in l10n as loginheading.label
- Added a create account link. This is in l10n as createaccount.label and should open a new tab in the browser that goes to https://addons.mozilla.org/en-US/firefox/users/register (well, the equivalent page on amo_host)
- added an image, which I'll attach to this bug. (will probably need to be resized to a size that you think fits well)

Also, Neil says that when he tried to login, the activity indicator wouldn't go away and he closed the window and opened it again and it had worked. Might be a bug.

Comment 1

[Justin Scott [:fligtar]]

Attachment: collections logo

Comment 2

[Brian King [:kinger]]

(In reply to comment #0)
> Please see the attached mockup. A few changes:
> - changed "username" to "e-mail address" - this is already reflected in l10n
> - Added a login form header part. This is in l10n as loginheading.label
> - Added a create account link. This is in l10n as createaccount.label and
> should open a new tab in the browser that goes to
> https://addons.mozilla.org/en-US/firefox/users/register (well, the equivalent
> page on amo_host)
> - added an image, which I'll attach to this bug. (will probably need to be
> resized to a size that you think fits well)

Done, revision 25149.

I scaled the logo to 150x176 using the Gimp. If it is too large or not high enough quality, just overwrite logo-login.png in skin/images/.
 
> Also, Neil says that when he tried to login, the activity indicator wouldn't go
> away and he closed the window and opened it again and it had worked. Might be a
> bug.

Neil, please file a new bug if you still see this. I saw this before but it may have been fixed recently as a side effect of other fixes.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; Krupa's been filing bugs on the functionality, but this bug was all about the polish.