[Extension] Polish up login window

VERIFIED FIXED in BW-M5

Status

VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: fligtar, Assigned: kinger)

Tracking

unspecified
BW-M5

Details

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
Created attachment 375119 [details]
mockup

Please see the attached mockup. A few changes:
- changed "username" to "e-mail address" - this is already reflected in l10n
- Added a login form header part. This is in l10n as loginheading.label
- Added a create account link. This is in l10n as createaccount.label and should open a new tab in the browser that goes to https://addons.mozilla.org/en-US/firefox/users/register (well, the equivalent page on amo_host)
- added an image, which I'll attach to this bug. (will probably need to be resized to a size that you think fits well)

Also, Neil says that when he tried to login, the activity indicator wouldn't go away and he closed the window and opened it again and it had worked. Might be a bug.
(Reporter)

Comment 1

10 years ago
Created attachment 375120 [details]
collections logo
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

10 years ago
(In reply to comment #0)
> Please see the attached mockup. A few changes:
> - changed "username" to "e-mail address" - this is already reflected in l10n
> - Added a login form header part. This is in l10n as loginheading.label
> - Added a create account link. This is in l10n as createaccount.label and
> should open a new tab in the browser that goes to
> https://addons.mozilla.org/en-US/firefox/users/register (well, the equivalent
> page on amo_host)
> - added an image, which I'll attach to this bug. (will probably need to be
> resized to a size that you think fits well)

Done, revision 25149.

I scaled the logo to 150x176 using the Gimp. If it is too large or not high enough quality, just overwrite logo-login.png in skin/images/.
 
> Also, Neil says that when he tried to login, the activity indicator wouldn't go
> away and he closed the window and opened it again and it had worked. Might be a
> bug.

Neil, please file a new bug if you still see this. I saw this before but it may have been fixed recently as a side effect of other fixes.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Verified FIXED; Krupa's been filing bugs on the functionality, but this bug was all about the polish.
Status: RESOLVED → VERIFIED
(Reporter)

Updated

9 years ago
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.