Closed Bug 490833 Opened 11 years ago Closed 11 years ago

mozIStorageStatement::getParameterIndex should only accept :-named parameters

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(3 files)

Attached patch v1.0Splinter Review
We should stop being so generic, and pick the same one that all of our js language helpers use.  I don't think anyone in native code land even uses named parameter support, so this shouldn't hurt them.

Now we only care about parameters that are named like :name.
Attachment #375182 - Flags: review?(bugmail)
Whiteboard: [needs review asuth]
Comment on attachment 375182 [details] [diff] [review]
v1.0

Is the UUID change to shake out any C++ users?
Attachment #375182 - Flags: review?(bugmail) → review+
(In reply to comment #1)
> Is the UUID change to shake out any C++ users?
Yes - we are supposed to change it for any behavior changes as well as interface additions.
Whiteboard: [needs review asuth] → [can land]
http://hg.mozilla.org/mozilla-central/rev/b6f09258a505
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1
I must have done a case sensitive search when I looked last time, so I missed native callers.  Had to back this out:
http://hg.mozilla.org/mozilla-central/rev/c60c37d487ca
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch content fix v1.0Splinter Review
Attachment #376732 - Flags: review?
Attachment #376732 - Flags: review? → review?(enndeakin)
Whiteboard: [needs review enn]
Attachment #376732 - Flags: review?(enndeakin) → review+
Whiteboard: [needs review enn]
Attached patch places fix v1.0Splinter Review
Attachment #376746 - Flags: review?(dietrich)
Whiteboard: [needs review dietrich]
Attachment #376746 - Flags: review?(dietrich) → review+
Whiteboard: [needs review dietrich]
Pushing this to the try server just to make sure, but this should be ready to land.
Whiteboard: [can land]
Try server was successful.  Pushed.
http://hg.mozilla.org/mozilla-central/rev/bb496ad42439
http://hg.mozilla.org/mozilla-central/rev/4aa0281ef45f
http://hg.mozilla.org/mozilla-central/rev/2a292f1b3565
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
You need to log in before you can comment on or make changes to this bug.