Closed
Bug 490833
Opened 15 years ago
Closed 15 years ago
mozIStorageStatement::getParameterIndex should only accept :-named parameters
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(3 files)
4.05 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
926 bytes,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
5.01 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
We should stop being so generic, and pick the same one that all of our js language helpers use. I don't think anyone in native code land even uses named parameter support, so this shouldn't hurt them. Now we only care about parameters that are named like :name.
Attachment #375182 -
Flags: review?(bugmail)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs review asuth]
Comment 1•15 years ago
|
||
Comment on attachment 375182 [details] [diff] [review] v1.0 Is the UUID change to shake out any C++ users?
Attachment #375182 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > Is the UUID change to shake out any C++ users? Yes - we are supposed to change it for any behavior changes as well as interface additions.
Whiteboard: [needs review asuth] → [can land]
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b6f09258a505
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Comment 4•15 years ago
|
||
I must have done a case sensitive search when I looked last time, so I missed native callers. Had to back this out: http://hg.mozilla.org/mozilla-central/rev/c60c37d487ca
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•15 years ago
|
||
Attachment #376732 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Attachment #376732 -
Flags: review? → review?(enndeakin)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs review enn]
Updated•15 years ago
|
Attachment #376732 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs review enn]
Assignee | ||
Comment 6•15 years ago
|
||
Attachment #376746 -
Flags: review?(dietrich)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs review dietrich]
Updated•15 years ago
|
Attachment #376746 -
Flags: review?(dietrich) → review+
Updated•15 years ago
|
Whiteboard: [needs review dietrich]
Assignee | ||
Comment 7•15 years ago
|
||
Pushing this to the try server just to make sure, but this should be ready to land.
Whiteboard: [can land]
Assignee | ||
Comment 8•15 years ago
|
||
Try server was successful. Pushed. http://hg.mozilla.org/mozilla-central/rev/bb496ad42439 http://hg.mozilla.org/mozilla-central/rev/4aa0281ef45f http://hg.mozilla.org/mozilla-central/rev/2a292f1b3565
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
You need to log in
before you can comment on or make changes to this bug.
Description
•