Improve performance of String.indexOf()/lastIndexOf()

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Michael Daumling, Assigned: Michael Daumling)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Performance has dropped sharply with the new string implementation.
(Assignee)

Comment 1

9 years ago
Created attachment 375220 [details] [diff] [review]
Fix

I've reverted the algorithm to the old one, and added a switch statement for all 8/16 bit combos. Performance is up 75-80%, which should match the old implementation. The fix has been tested on Win only, but should work fine on all other platforms. Steven, if you accept the fix, can you, please, push it - I am on the road till Wednesday.
Attachment #375220 - Flags: review?(stejohns)

Comment 2

9 years ago
Comment on attachment 375220 [details] [diff] [review]
Fix

sorry for the delay in reviewing. do you still need me to push it for you?
Attachment #375220 - Flags: review?(stejohns) → review+

Comment 3

9 years ago
pushed to redux as changeset:   1856:0388b74ac104
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 4

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.