490897 - Collection Management styling

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

This is a bug for styling the Collection management pages with the new site layout and design.

Comment 1

[Fred Wenzel [:wenzel]]

(depends on bug 490896, the collection creation styling)

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This patch dresses the collections edit page up nicely :)

Comment 3

[Fred Wenzel [:wenzel]]

Note to self: I need to make sure the JavaScript code matches bug 492685 before committing this, so there won't be a regression.

Comment 4

[Ryan Doherty (:rdoherty)]

(In reply to comment #2)
> Created an attachment (id=378102) [details]
> Patch, rev. 1
> 
> This patch dresses the collections edit page up nicely :)

Since this depends on bug 490896, this probably needs a new, up to date diff.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

Yes, this one was out of date, too.

Comment 6

[Ryan Doherty (:rdoherty)]

Comment on attachment 378546 [details] [diff] [review]
Patch, rev. 2

Overall good, just a few tiny things.

If I enter a collection name with a quote (' or ") it shows up escaped in the input box (')

(not a part of the bug really, I can file a new one if you'd like)

Also, we can't use @media queries in our stylesheets as the CSS concatenation process wraps our css with the same queries, which will probably break. (/** jQuery UI tabs */)

On a side note: Glad to see -moz-column-count!

Comment 7

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 3

I fixed the two issues you pointed out. For the CSS part (most of which was copied from on of that jQuery plugin's default styles), I just removed the rules for printing. I don't think anyone would want to print that page and wind up highly disappointed that the tabs were present in their printout.

Comment 8

[Ryan Doherty (:rdoherty)]

Comment on attachment 379100 [details] [diff] [review]
Patch, rev. 3

Looks awesome!

Comment 9

[Fred Wenzel [:wenzel]]

r26097, thanks!

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collections/edit/787694ee-692f-102c-9a23-001e0bd9232c; will, as usual, file new bugs for things we notice going forward.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"