Closed
Bug 490969
Opened 15 years ago
Closed 15 years ago
More random header include tidy up
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
11.05 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I found this patch in my queue, thought we might as well put it into the code base to tidy up our header includes a little bit more.
Attachment #375314 -
Flags: superreview?(bienvenu)
Attachment #375314 -
Flags: review?(bienvenu)
Comment 1•15 years ago
|
||
Comment on attachment 375314 [details] [diff] [review] The fix this fails on my windows build: Building deps for /tbirdhg/mailnews/base/src/nsMessengerWinIntegration.cpp nsMessengerWinIntegration.cpp C:/mozilla-build/msys/tbirdhg/mailnews/base/src/nsMessengerWinIntegration.cpp(149) : error C2065: 'nsIMsgWindowCommands' : undeclared i dentifier C:/mozilla-build/msys/tbirdhg/mailnews/base/src/nsMessengerWinIntegration.cpp(149) : error C2133: 'windowCommands' : unknown size C:/mozilla-build/msys/tbirdhg/mailnews/base/src/nsMessengerWinIntegration.cpp(149) : error C2512: 'nsCOMPtr' : no appropriate default c onstructor available C:/mozilla-build/msys/tbirdhg/mailnews/base/src/nsMessengerWinIntegration.cpp(150) : error C2027: use of undefined type 'nsIMsgWindow' C:\mozilla-build\msys\tbirdhg\objdir-tb\mozilla\dist\include\msgbase\nsIMsgIncomingServer.h(25) : see declaration of 'nsIMsgWin dow' C:/mozilla-build/msys/tbirdhg/mailnews/base/src/nsMessengerWinIntegration.cpp(150) : error C2039: 'GetWindowCommands' : is not a member of 'nsCOMPtr<T>' with [ T=nsIMsgWindow ]
Comment 2•15 years ago
|
||
Comment on attachment 375314 [details] [diff] [review] The fix if you add an include of "nsIMsgWindow.h" to nsMessengerWinIntegration.cpp, and most likely nsMessengerUnixIntegration.cpp, r/sr=me.
Attachment #375314 -
Flags: superreview?(bienvenu)
Attachment #375314 -
Flags: superreview+
Attachment #375314 -
Flags: review?(bienvenu)
Attachment #375314 -
Flags: review+
Assignee | ||
Comment 3•15 years ago
|
||
Patch checked in with the two additions: http://hg.mozilla.org/comm-central/rev/eef20451fde6
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•