Closed Bug 490972 Opened 13 years ago Closed 13 years ago

Switch parts of nsIImapUrl to ACString to save string copies/allocations

Categories

(MailNews Core :: Networking: IMAP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

Details

(Keywords: memory-footprint, perf)

Attachments

(1 file)

Attached patch The fixSplinter Review
I've had this patch sitting around for a while - must be time to get it in.

It switches some of the attributes in nsIImapUrl from type string to type ACString. This has the effect of reducing the amount of getter_Copies we need to call those functions and I think saving at least one string allocation along the way.

Hence this should help performance and bloat by some tiny amount.
Attachment #375318 - Flags: superreview?(bienvenu)
Attachment #375318 - Flags: review?(bienvenu)
Attachment #375318 - Flags: superreview?(bienvenu)
Attachment #375318 - Flags: superreview+
Attachment #375318 - Flags: review?(bienvenu)
Attachment #375318 - Flags: review+
Checked in: http://hg.mozilla.org/comm-central/rev/db857c5e58e8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.