490994 - If i open a file without a seamonkey window open it opens two windows of the file (DDE message data in "ddeexec" sub key, garbage by old Sm 2 Alpha, interferes start of Sm, because no -requestPending in SeamonkeyHTML\shell\open\command)

Status: NEW

(SeaMonkey :: General, defect)

Description

[andrew.hayzen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090501 SeaMonkey/2.0b1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090501 SeaMonkey/2.0b1pre

If i haven't go SeaMonkey open and i double click on a .HTML file (i haven't tested with any other file types) SeaMonkey will open two copies of the file either in two tabs or two windows. However if SeaMonkey is open then this doesn't happen.

Reproducible: Always

Steps to Reproduce:
1. get any .HTML file
2. make sure SeaMonkey isn't open
3. open the file 
Actual Results:  
SeaMonkey will open two copies of the file either in two tabs or two windows

Expected Results:  
SeaMonkey should open one copy of the file.

Comment 1

[Robert Kaiser]

Frank, didn't we have such a bug somewhere already?

Comment 2

[Frank Wein [:mcsmurf]]

Yes, Bug 461501, but that one should be fixed...
Andrew: Does the value in HKEY_CLASSES_ROOT\SeaMonkeyHTML\shell\open\command look like this in your registry: (PathToSeaMonkey.exe) -url "%1"? Or does it include something like "-requestPending" in that URL?

Comment 3

[Frank Wein [:mcsmurf]]

(In reply to comment #2)
> include something like "-requestPending" in that URL?

I meant "value", not URL

Comment 4

[andrew.hayzen]

mine says "C:\Program Files\SeaMonkey\seamonkey.exe" -url "%1"

Comment 5

[WADA:World Anti-bad-Duping Agency]

Same phenomenon could be observed with Sm latest-trunk 2009-5-02 build on MS Win-XP.

- Sm nightly is set as default browser. Sm is not active.
- Sm is invoked by double click of ...html file at Windows Explorer.

(Case-1) Multiple profiles, "Don't ask at startup" is checked.
   Two Sm windows for the HTML file were opened.

(Case-2) Multiple profiles, "Don't ask at startup" is NOT checked.
   - Profile selection panel is displaed.
   - Next dialog was also displayed.
     (In Japanese, so not accurate English message text.)
> C:\$TXT\test-2.html
>  X 'C:\\test-2.html'is not found. After checking whether you entered correct name or not, retry.
>    To search file, open "Start" menu and click "Search".

In my environment, "Use DDE" option in Folder Options/File Types/HTML/open is enabled as deafult. So It looks;
(1) Two DDE messages are thrown by MS Win.
(2-A) If "Don't ask at startup" is checked, Sm processes both two DDE messages.
(2-B) If "Don't ask at startup" is NOT checked, Sm responds to first DDE message and displays profile selection panel. But Sm doesn't respond to second DDE message. Then MS Win displays error dialog.

Comment 6

[Frank Wein [:mcsmurf]]

WADA, Andrew: Can you test if deleting the HKEY_CLASSES_ROOT\SeaMonkeyHTML registry entry and then re-setting SeaMonkey as default browser changes anything? Just wondering if there is some old registry entry present (this key changed a few month ago from DDE to non-DDE). And now that I look at the code, this might actually help as we now just write a non-DDE registry entry, but did not delete the old dde registry sub key. If there is no "-requestPending" parameter in the URL (as noted in Comment 4) we do not ignore the upcoming DDE request.
btw: The "Use DDE" option does not seem to reflect what is stored in registry, it seems to be what Windows would like to do ;). HKEY_CLASSES_ROOT\SeaMonkeyHTML\shell\open does not contain a "ddeexec" sub key, but when I open the dialog, the "Use DDE" option is checked anyway. When I click on OK, Windows creates the "ddeexec" sub-entry.

Comment 7

[WADA:World Anti-bad-Duping Agency]

After deletion of the key, next entry was created, but "ddeexec" sub key was not created, by both Sm trunk 2009/5/02 build and Sm 1.1.5.
> HKEY_CLASSES_ROOT\SeaMonkeyHTML\shell\open\command "C:\...\seamonkey.exe" -url "%1"
Problem was not reproduced after that.

Note-1:
"Change Fx2 to default browser" is required to force Sm 1.1.5 to ask "set as  default browser or not" again.
Note-2:
Firefox(3/latest-trunk is used) sets next value, and "ddeexec" sub key exists.
> HKEY_CLASSES_ROOT\FirefoxHTML\shell\open\command "C:\...\firefox\firefox.exe" -requestPending -osint -url "%1"
As Frank Wein says, no problem because of -requestPending, even when "ddeexec" sub key exists.

Comment 8

[Frank Wein [:mcsmurf]]

Not sure if we really want to add code to fix this bug here as this problem only affects people who used SeaMonkey 2.0 alpha builds before 2008-12-02 (see Bug 461501 where this was changed).

Comment 9

[WADA:World Anti-bad-Duping Agency]

When I edited File Type/open setting for HTML("Use DDE" is checked by MS Win, but null "DDE message" value), MS Win created SeaMonkeyHTML\shell\open\ddeexec subkey.
But problem was not reproduced.
After putting "DDE message" value, problem was reproduced.
> HKEY_CLASSES_ROOT\SeaMonkeyHTML\shell\open\ddeexec
>  Name       Type    Data 
>  (default)  REG_SZ  "%1",,0,0,,,,   (same value as FirefoxHTML\shell\open\ddeexec)

Frank Wein, is this the garbage by Seamonkey 2.0 alpha(and old Seammonkey/Firefox trunk builds)?

Comment 10

[andrew.hayzen]

Just to confirm deleting the registry key (Below) does stop this error happening.
HKEY_CLASSES_ROOT\SeaMonkeyHTML\shell\open\command

thanks guys,

Andrew

Comment 11

[WADA:World Anti-bad-Duping Agency]

Reflecting comment #6 and comment #8 into bug summary, for ease of search.

Comment 12

[Frank Wein [:mcsmurf]]

(In reply to comment #9)
> When I edited File Type/open setting for HTML("Use DDE" is checked by MS Win,
> but null "DDE message" value), MS Win created SeaMonkeyHTML\shell\open\ddeexec
> subkey.
> But problem was not reproduced.
> After putting "DDE message" value, problem was reproduced.
> > HKEY_CLASSES_ROOT\SeaMonkeyHTML\shell\open\ddeexec
> >  Name       Type    Data 
> >  (default)  REG_SZ  "%1",,0,0,,,,   (same value as FirefoxHTML\shell\open\ddeexec)
> 
> Frank Wein, is this the garbage by Seamonkey 2.0 alpha(and old
> Seammonkey/Firefox trunk builds)?

Yes.

Comment 13

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #12)
> > Frank Wein, is this the garbage by Seamonkey 2.0 alpha(and old Seammonkey/Firefox trunk builds)?
> Yes.

I think any of next is acceptable.
(1) Change SeaMonkeyHTML\shell\open\command to "... -requestPending -osint ..."
(2) Add code to delete garbage(DDE message) in SeaMonkeyHTML\shell\open\ddeexec 
(3) Close this bug as WONTFIX, and kindly add description in "Release Notes"
    for Seamonkey Trunk/Alpha testers.
(4) Close this bug as WONTFIX, and do nothing.

I think, even if problem occurs on all Sm Trunk/Alpha testers, number of victims is very small. And, even If Sm Trunk/Alpha testers will meet this bug, no problem will occur if Sm Trunk/Alpha tester reaches this bug, by himself, or via MozillaZine/Mozilla Wiki docs, or by help at forums or B.M.O, or if tester fortunately/accidentally deletes garbage of "DDE message" data in SeaMonkeyHTML\shell\open\ddeexec. And, even if Sm Trunk/Alpha tester can't reach this bug, it'll never produce "flood of bug reports of complaint", because "Trunk/Alpha testers of Sm", not "casual Alpha/Beta/Trunk user of Fx".
I think (3) is acceptable.

Comment 14

[James Hall]

Attachment: same problem

Thanks from aptitesphy1972.