49102 - Do not change the "more" submenus anymore

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P2)

Description

[cata]

Currently, when the charset menu is created, we take the items in "static" and 
"cache" and not put them in the "more" submenus anymore. But when we change 
those two areas (by editing or simply navigating) we don't update the submenus. 
That is bad: imagine the situation when you don't have a charset in the submenus 
because it is in cache, but then you navigate and it gets purged out of cache, 
and you don't have that charset anywhere in the whole menu!

So, there are two solutions. We can update the submenus all the time but this is 
way too complicated. So I'll just let them to be unchanged, having the complete 
list of charsets all the time.

Comment 1

[cata]

More work that should be included in this bug: review the charset exclusion 
code. This allows us to specify that a certain charset should be 
included/excluded in the charset menu. The need to review this code is that 
initially the mechanism was separated for browser/composer/mail/mailedit. That 
changed, so I need to make sure everything is ok.

Comment 2

[cata]

*** Bug 51454 has been marked as a duplicate of this bug. ***

Comment 3

[cata]

Attachment: Proposed fix

Comment 4

[cata]

I have a fix. We'll simply use a different list of charsets when adding to the 
cache and static area (when we don't want to substract) and when adding to the 
more submenus (when we want to substract).

Patch attached, need review! (The "extra work" was done, too...)
Nominating for nsbeta3...

Comment 5

[cata]

nsbeta3+ P2 by ftang

Comment 6

[cata]

And fixed.

Comment 7

[Teruko Kobayashi]

Verified as fixed in 2000-09-15-05 build.