491027 - Pressing tab on last entry in tag autocomplete popup breaks the editBookmarkPanel

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090427 Shiretoko/3.5b5pre ID:20090427031112

Using the tab key twice when entering a tag into the tags field inside the editBookmarksPanel widen the whole panel and makes the tags textfield wonky for user interaction.

Steps:
1. Open a page, bookmark it, and give a tag like 'test'
2. Open another page and bookmark it too
3. Focus the tag field and enter 't'
4. Hit space to select the first entry in the autocomplete popup 
5. Hit space again

After step 5 the panel widens and leaves the popup on the right side. Selecting another element on the panel and clicking the tag textfield afterward at the right side, doesn't set the focus to the textbox. You have to restart the browser to get it fixed.

This should be a recent regression (probably in the last month) on 1.9.1.

Comment 1

[Drew Willcoxon :adw]

Confirming here.  Steps 4 and 5 above mention space, but I think tab is what was meant.  Sometimes the tag panel remains wide, so that the next time you bookmark a page the add bookmark panel is too wide on open, and sometimes not.  So I can't confirm that a restart is needed to fix the problem.

The panel also widens when you click the folder progressive disclosure button -- as expected -- but the problem described here causes the panel to grow wider than that. 

Marco tells me he thinks it might be an autocomplete widget problem.

Comment 2

[David Dahl :ddahl]

This is a WFM on linux.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Steven, could this be a widget problem?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking, does suck, absolutely wanted.

Josh/mstange: any ideas what might have caused this?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As what I can see this happens only when pressing tab while the last entry in the tag autocomplete popup is selected.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

This bug happens on mozilla-central and the 1.9.1 branch, but not on
the 1.9.0 branch (on OS X).  It doesn't happen at all on Windows or
Linux.

Here are the regression ranges:

mozilla-central

2009-04-20-03-mozilla-central
2009-04-21-03-mozilla-central

1.9.1 branch

2009-04-19-03-mozilla-1.9.1
2009-04-20-03-mozilla-1.9.1

Oddly, the problem seems to appear on the 1.9.1 branch before it does
on mozilla-central.  Or maybe I've made a mistake.  Henrik, please
double-check the regression ranges.

I'm strongly tempted to say this bug was caused (or at least
triggered) by the patch for bug 488255 ... which at least landed on
mozilla-central in the right time range.

Note that steps 4 and 5 in comment #0 are wrong -- "Hit space" should
be "Hit tab".

Comment 7

[Steven Michaud [:smichaud] (Retired)]

> Here are the regression ranges:
>
> ...
>
> 1.9.1 branch
>
> 2009-04-19-03-mozilla-1.9.1
> 2009-04-20-03-mozilla-1.9.1

Yes, I did make a mistake.  The 1.9.1 branch regression range is the
same as the mozilla-central one:

2009-04-20-03-mozilla-1.9.1
2009-04-21-03-mozilla-1.9.1

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)

Thanks Steven in helping to track it down.

> 2009-04-20-03-mozilla-central
> 2009-04-21-03-mozilla-central

ACK.

> 1.9.1 branch
> 
> 2009-04-19-03-mozilla-1.9.1
> 2009-04-20-03-mozilla-1.9.1

Here is a mistake. It regressed between 09042003 and 09042103

> I'm strongly tempted to say this bug was caused (or at least
> triggered) by the patch for bug 488255 ... which at least landed on
> mozilla-central in the right time range.

Changeset pass: 71a5ebd9a59c
Changeset fail: cfb24602548b

Check-ins: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=71a5ebd9a59c&tochange=cfb24602548b

It's definitely the correct bug. Updating the dependency list.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Not a polish bug, but more of an actual bug bug.

Comment 10

[Michelle Funches - QA]

Cannot reproduce
Version 	47.0.1
Build ID 	20160623154057
User Agent 	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0