Closed Bug 491030 Opened 15 years ago Closed 15 years ago

Not valid XHTML in mail_help.xhtml after fixing bug 489169

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: rpmdisguise-nave, Assigned: rpmdisguise-nave)

References

Details

Attachments

(1 file)

Attached patch Proposed patchSplinter Review
While fixing bug 489169, two <p> elements have been added as children of <ol> elements, which is not conforming to XHTML 1.1. They should be inside <li> items. I attach a proposed patch.
That's probably correct. These two occurrences were converted from proposed <li> items to <p>, thus should have moved into the previous list item.

Please ask stefanh for review of your patch to get this corrected.
Blocks: 489169
Attachment #375364 - Flags: review?(stefanh)
(In reply to comment #1)
> Please ask stefanh for review of your patch to get this corrected.

Done.
--- ../MT/comm-central/suite/locales/en-US/chrome/common/help/mail_help.xhtml	2009-04-30 20:25:48.000000000 +0200
+++ fixed_mail_help.xhtml	2009-05-01 20:23:42.000000000 +0200

Did you edited the diff? Because I tried to fix up the paths, but the patch doesn't apply.
(In reply to comment #3)
> --- ../MT/comm-central/suite/locales/en-US/chrome/common/help/mail_help.xhtml  
>  2009-04-30 20:25:48.000000000 +0200
> +++ fixed_mail_help.xhtml    2009-05-01 20:23:42.000000000 +0200
> 
> Did you edited the diff? Because I tried to fix up the paths, but the patch
> doesn't apply.

No, I have the command line I've used right here:

[rpalomares@Father tmp]$ diff -U 8 ../MT/comm-central/suite/locales/en-US/chrome/common/help/mail_help.xhtml fixed_mail_help.xhtml >fix_for_bug_489169.patch

And I've uploaded the file as it has been created. :-?
The patch is missing the empty lines in 886 and 919 of the current version.
(In reply to comment #5)
> The patch is missing the empty lines in 886 and 919 of the current version.


It's strange. It is true that the file has those empty lines if I see it through hg.mozilla.org, but I've just run python client.py checkout and opening the file in Bluefish HTML editor or dumping the file through less shows NO empty lines there (verified with an hexadecimal editor). Windows vs. Unix line endings, maybe?

I could manually modify my local copy of comm-central mail_help.xhtml, do the modifications again and provide a new patch, but I don't know if that would work. :-?
Comment on attachment 375364 [details] [diff] [review]
Proposed patch

I fixed the patch manually and it looks good to me ;-)

Not sure how you've managed to miss those lines in your local repo. Maybe you should get a fresh clone.
Attachment #375364 - Flags: review?(stefanh) → review+
We do unix line endings, btw.
(In reply to comment #7)
> (From update of attachment 375364 [details] [diff] [review])
> I fixed the patch manually and it looks good to me ;-)
> 
> Not sure how you've managed to miss those lines in your local repo. Maybe you
> should get a fresh clone.


I'd rather wait for the new file version to see if it gets fixed. It is a bit annoying to download 1,5 GBytes just because two missing "0x0A" bytes. :-)

BTW, just in case, I don't have write rights to comm-central (I'm just a localizer), :-) so I will need that somebody else do it.
Stefan, can you check in your cleaned-up patch or do you want me to provide one which applies?

BTW: Sorry for the glitch and thanks for the quick fix!
(In reply to comment #9)

> BTW, just in case, I don't have write rights to comm-central (I'm just a
> localizer), :-) so I will need that somebody else do it.

(In reply to comment #10)
> Stefan, can you check in your cleaned-up patch or do you want me to provide one
> which applies?
> 

I midaired with both of you.. Ricardo, I just landed your (slightly modified) patch as http://hg.mozilla.org/comm-central/rev/f1915cdc24a9. Thanks for spotting/fixing this!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee: nobody → rpmdisguise-otros
Blocks: 423281
You need to log in before you can comment on or make changes to this bug.