491038 - User should be not allowed to upload files to a version if the platform selection is set to "ALL"

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Steps to reproduce:
1.log into your developer account
2.Submit an add-on and choose any custom license.(my add-on name:zaphod123).Choose platform=ALL
3.Edit the addon and update details like category,description and status
4.Go back to Developer Tools and select the same add-on
5.Click on Versions and Files.
6.Choose to add files to the existing version

expected result:
User is not allowed to upload files to a version if the platform selection is set to "ALL"

Observed behavior:
User can upload files to the same version when Platform=ALL.This results in multiple buttons for the add-on for the same platform selection.

Comment 1

[RJ Walsh [:rjwalsh]]

Attachment: Fix

Prevents platform overlap between an existing platform and all platform versions

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 394876 [details] [diff] [review]
Fix

I can still upload new files for any platform, even if platform=ALL already exists.

Comment 3

[RJ Walsh [:rjwalsh]]

Attachment: v2

Reworked to use DB instead of filesystem

Comment 4

[Justin Scott [:fligtar]]

fwiw, I implemented it like this intentionally because otherwise you would have to delete the existing ALL file and your version would have no files in it for the time between deleting the old file and getting the new one approved.

Comment 5

[RJ Walsh [:rjwalsh]]

(In reply to comment #4)
> fwiw, I implemented it like this intentionally because otherwise you would have
> to delete the existing ALL file and your version would have no files in it for
> the time between deleting the old file and getting the new one approved.

Justin - I guess this poses the question of whether it's worth it to fix this bug.  Is there a better model than the current one to make this work?

Comment 6

[Justin Scott [:fligtar]]

I don't have any great ideas that won't make things super complicated.

I am fine with fixing this bug or not fixing this bug.

Comment 7

[RJ Walsh [:rjwalsh]]

Alright, I'll just send this back to nobody in the event that someone else has a better way to do this.

Comment 8

[Wil Clouser [:clouserw]]

And I'll wontfix it in case someone doesn't.  Thanks RJ.