Closed Bug 491050 Opened 15 years ago Closed 15 years ago

improve nsIFile's GetFileSize on Mac OS X, stop using FSGetCatalogInfo

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

fix v1.1
1.53 KB, patch
roc
: superreview+
Details | Diff | Splinter Review
Attached patch fix v1.0 (obsolete) — — Splinter Review 
We should just use stat to get file size on Mac OS X, no need for Carbon stuff like FSGetCatalogInfo.
Attachment #375383 - Flags: review?(mstange)
Attachment #375383 - Flags: review?(mstange) → review+
Attached patch fix v1.1 — — Splinter Review 
remove now-unnecessary obj-c exception guards
Attachment #375383 - Attachment is obsolete: true
Attachment #375402 - Flags: superreview?(roc)
Attachment #375402 - Flags: superreview?(roc) → superreview+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/88813ac52262
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: