improve nsIFile's GetFileSize on Mac OS X, stop using FSGetCatalogInfo

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
All
macOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.53 KB, patch
Details | Diff | Splinter Review
Posted patch fix v1.0 (obsolete) — Splinter Review
We should just use stat to get file size on Mac OS X, no need for Carbon stuff like FSGetCatalogInfo.
Attachment #375383 - Flags: review?(mstange)
Attachment #375383 - Flags: review?(mstange) → review+
Posted patch fix v1.1Splinter Review
remove now-unnecessary obj-c exception guards
Attachment #375383 - Attachment is obsolete: true
Attachment #375402 - Flags: superreview?(roc)
Attachment #375402 - Flags: superreview?(roc) → superreview+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/88813ac52262
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.