491068 - Need a nestable version of MMGC_GCENTER for auto heap-stack handling

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Tommy Reilly]

Some player configs switch to a heap area for stack usage and we need to inform the GC that there are essentially two stacks too track in this case.  Currently nested MMGC_GCENTER macros are ignored, which is the desired behavior, so this will be a new macro, MMGC_GCENTER_NESTED or something like that.  It will be a C++ auto object run after the auto heap-stack switching has happened and it will establish the old now fixed stack as a temporary GCRoot.  The destructor will delete the temporary GCRoot and re-establish the original MMGC_GCENTER.

Comment 1

[Tommy Reilly]

Attachment: implements desired functionality plus one stubbed API for FRR

Comment 2

[Tommy Reilly]

This feature feature request and the Flash debugger are the same, hence the new name MMGC_GC_ROOT_THREAD.

Comment 3

[Lars T Hansen]

Comment on attachment 378868 [details] [diff] [review]
implements desired functionality plus one stubbed API for FRR

The QueueFullCollection API does not seem to belong with this patch and I'd be more comfortable if you removed it.  If you do need to land it now (eg to enable somebody else to get work done) then it should be fixed so that it interacts with the policy manager; the state variable should be kept there, not in class GC.  (It seems to me that just providing an empty QueueFullCollection method would be OK for now.)

Comment 4

[Tommy Reilly]

Agreed, will fix in upcoming patch, apparently Steven's at a good spot now so no more empty API patches

Comment 5

[Tommy Reilly]

changeset:   1920:b24ecd4559de
user:        Tommy Reilly <[e-mail]>
date:        Thu May 21 11:02:00 2009 -0400
summary:     Add API's for FRR purposes.  MMGC_GC_ROOT_THREAD and QueueCollection