Closed
Bug 491091
Opened 17 years ago
Closed 17 years ago
Spaces are replaced by newline character(\n) and carriage return(\r) when collection submission fails
Categories
(addons.mozilla.org Graveyard :: Collections, defect)
addons.mozilla.org Graveyard
Collections
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.6
People
(Reporter: krupa.mozbugs, Assigned: lorchard)
References
()
Details
Attachments
(2 files)
|
131.58 KB,
image/png
|
Details | |
|
1.09 KB,
patch
|
wenzel
:
review+
|
Details | Diff | Splinter Review |
steps to reproduce:
1.Log in to your AMO account.
2.Navigate to Collections Home
3.Click on "Create a collection"
4.Do NOT enter a collection name
5.Enter collection description ...like-
"Take the juice from one bottle of that Ol' Janx Spirit.
Pour into it one measure of water from the seas of Santraginus V
Allow three cubes of Arcturan Mega-gin to melt into the mixture (it must be properly iced or the benzene is lost).
Allow four litres of Fallian marsh gas to bubble through it (in memory of all those happy Hikers who have died of pleasure in the Marshes of Fallia).
....
Add an olive.
Drink...but very carefully."
5.Click create collection button
6.Submission fails.
7.Now enter a collection name and submit
8.Notice the description
observed behavior:
Space is replaced by \r\n
Updated•17 years ago
|
Assignee: nobody → lorchard
| Assignee | ||
Comment 1•17 years ago
|
||
Attachment #375909 -
Flags: review?(fwenzel)
Updated•17 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 2•17 years ago
|
||
Comment on attachment 375909 [details] [diff] [review]
Running model validation before Amo->clean() so as not to munge data before form population
Yes, this wfm.
Attachment #375909 -
Flags: review?(fwenzel) → review+
| Assignee | ||
Comment 3•17 years ago
|
||
checked in as r25282
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 4•17 years ago
|
||
I created a new collection following steps mentioned in the bug.But I still the same behavior.
https://bandwagon.stage.mozilla.com/en-US/firefox/collections/view/21e2663f-3a25-8f49-1fd1-1dca148f65a1
Reopening...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•17 years ago
|
||
Per bug 490888, you should be testing on preview.
| Reporter | ||
Comment 6•17 years ago
|
||
oops,my mistake Verified on preview.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
| Reporter | ||
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•