491095 - Consider adding a character limit to collection names

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[krupa raj[:krupa]]

Attachment: long add-on name

Collection names have no character limit.Please,consider adding one.
See screenshot for reason.

Comment 1

[Wil Clouser [:clouserw]]

Let's make it the same as add-on names.

Comment 2

[Justin Scott [:fligtar]]

50 characters, per https://bug456132.bugzilla.mozilla.org/attachment.cgi?id=373208 and the spec.

Comment 3

[Jeff Balogh (:jbalogh)]

Attachment: bug 491087 and bug 491095, adding limits to collection name and description

This is incomplete, but I wanted to hear what you think before I go too far down this road.

I'd like to move the invalidFields function to app_model, so all models can do the clean_$field trick.

There's still too much separation between validation and error messages; the validator function is the best place to set error messages.

Putting all this in models is wrong, but it's the easiest place to start since all the other validation is attached to models.

Comment 4

[Jeff Balogh (:jbalogh)]

Attachment: moving the error messages to the validator function

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 376093 [details] [diff] [review]
moving the error messages to the validator function

Works for me if you add ___()

Comment 6

[Jeff Balogh (:jbalogh)]

r25399

Comment 7

[Fred Wenzel [:wenzel]]

Jeff: I think your validation method is good, but you should put it into app_model.php. We already have a (much more complicated, inported from the cake guys) validation method in there and we should not duplicate that code.

Comment 8

[krupa raj[:krupa]]

Filed related bug  Bug 492461

Marking this bug as verified.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"