491120 - Prism build fails, because prism/common/Makefile.in is missing

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Saša Bodiroža]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4pre) Gecko/20090401 Ubuntu/9.04 (jaunty) Shiretoko/3.5b4pre
Build Identifier: 0.9.9+svn20090429r25045

Hello,

Ubuntu daily build of Prism failed because prism/common/Makefile.in is missing. We solved this by removing "common" from DIRS variable in prism/Makefile.in.

Reproducible: Always

Steps to Reproduce:
Get latest revision from trunk, and start build.
Actual Results:  
The build fails, reporting that prism/common/Makefile.in is missing.

Expected Results:  
The build should complete without errors.

Comment 1

[Saša Bodiroža]

Attachment: Patch that removes "common" from DIRS in prism/Makefile.in

Comment 2

[Alexander Sack]

Comment on attachment 375460 [details] [diff] [review]
Patch that removes "common" from DIRS in prism/Makefile.in

our daily builds started to fail because of this.

Comment 3

[Alexander Sack]

... besides from that current daily builds don' seem to work that great for us - maybe some rework going on. lets see what todays build give us.

Comment 4

[Matthew Gertner]

Attachment: Makefile for build/ directory

This change was to ensure that the build happens in the right order, otherwise all the module files don't show up until the second build. I've moved the change to the build/ directory and put the preferences there as well since there was a problem with preferences not showing up either in a fresh build.

Comment 5

[Matthew Gertner]

Sending        Makefile.in
Adding         build/Makefile.in
Transmitting file data ..
Committed revision 25218.