View - Feed Message Body As - Default doesn't work

RESOLVED FIXED in seamonkey2.0b1

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Ian Neal)

Tracking

unspecified
seamonkey2.0b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
newsblog's utils.js defines const RDF_NS but suite's bookmarks.js (as used by the Bookmark This Link context menu option) already declares it as a var. This means that an exception is thrown when the view as default code tries to dynamically import utils.js and therefore nothing gets shown at all.
(Assignee)

Comment 1

9 years ago
As it is only used in one line in utils.js could just do remove:

const RDF_NS = "http://www.w3.org/1999/02/22-rdf-syntax-ns#";
const RDF_TYPE = rdf.GetResource(RDF_NS + "type");

and instead have:

const RDF_TYPE = rdf.GetResource("http://www.w3.org/1999/02/22-rdf-syntax-ns#type");
(Reporter)

Comment 2

9 years ago
Yeah, that works, thanks.
(Assignee)

Updated

9 years ago
Depends on: 438429
(Assignee)

Comment 3

9 years ago
Created attachment 375596 [details] [diff] [review]
Fix duplicate declaration v0.1 (Pushed: Comment 4)

This patch:
* Removes duplicate declaration from newsblog's utils.js so it does not break View -> Feed Message Body As -> Default in SeaMonkey.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #375596 - Flags: review?(bugzilla)
Attachment #375596 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

9 years ago
Attachment #375596 - Flags: superreview?(bienvenu)

Updated

9 years ago
Attachment #375596 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 4

9 years ago
Comment on attachment 375596 [details] [diff] [review]
Fix duplicate declaration v0.1 (Pushed: Comment 4)

http://hg.mozilla.org/comm-central/rev/2580d4920e20
Attachment #375596 - Attachment description: Fix duplicate declaration v0.1 → Fix duplicate declaration v0.1 (Pushed: Comment 4)
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Target Milestone: --- → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.