491180 - button elements clip their contents, but should not

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[jet1972]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090502 Shiretoko/3.5b5pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090502 Shiretoko/3.5b5pre (.NET CLR 3.5.30729)

The logos on this page are only shown partly.

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed on Windows XP. Regression range is: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-01-25+16%3A00&maxdate=2006-01-26+10%3A00

Comment 2

[Matthias Versen [:Matti]]

marking new

Comment 3

[Ernst de Haan]

Confirmed on Mac OS X 10.5.6 (nl_NL) / Firefox 3.5b4.

I've done a little poking around using Firebug, but indeed this looks like a Firefox bug. When I look at the size of one of the IMG elements in the page, its size is sufficient to show the whole picture, but it does not.

Then when I look at the IMG source file:
https://eservice.nordeafinance.com/P6248/Images/sampologo.gif
I do get the complete picture.

Alternatively, this may be a CSS-related error in the website.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

need a reduced testcase.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Cancelling request until we have enough data to show it's a real bug.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: mostly-simplified testcase

The problem is that button elements are clipping their contents; they don't seem to do so in WebKit, and I'm guessing they didn't before frame display lists landed.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The expected results in the testcase are that the entire 32x32 white square with a black border should be visible; currently the bottom (which sticks outside the fuchsia button) is being cut off.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: other cases worth checking across browsers

Not sure if the position:relative matters; worth checking.

Comment 9

[Boris Zbarsky [:bzbarsky]]

See also bug 503289.

My testing shows that:

1)  Opera clips the non-rel-pos content, but doesn't clip the rel pos content.
2)  Safari doesn't clip period, including this testcase:

  data:text/html,<button style="width:0px">aaaaaaaaaaa</button>

3)  Safari does clip this:

  data:text/html,<input value="aaaaaaaaa" type="button" style="width:0px">

I think the <input> behavior is needed for web compat.  I'd support switching to the safari behavior for <button>. That means conditioning the OverflowClip in nsHTMLButtonControlFrame::BuildDisplayList on what content node we have.  That doesn't seem too terrible to me.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Oh, and the Firefox 2 behavior (so from before display lists) was like Opera's.  It was an obvious artifact of rel pos frames having views.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: This looks like it should give us the Webkit behavior

Comment 13

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/12728e187734

Comment 14

[Joshua Mitchell (Inactive)]

Issue is Resolved - removing QA-Wanted Keywords - QA-Wanted query clean-up task