fix warnings in qcms

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
GFX: Color Management
--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla1.9.2a1
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

9 years ago
Created attachment 375516 [details] [diff] [review]
patch
Attachment #375516 - Flags: review?(bobbyholley)
Attachment #375516 - Flags: review?(bobbyholley) → review?(jmuizelaar)
Comment on attachment 375516 [details] [diff] [review]
patch

jeff should look at this instead.
Comment on attachment 375516 [details] [diff] [review]
patch

Looks fine to me.
Attachment #375516 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 4

9 years ago
hey, do i need additional reviews? and does this need to go to some upstream first?

i'm not really baby sitting patches (i'm filing dozens of patches and hoping others will magically push them into the tree).
Attachment #375516 - Flags: superreview?(pavlov)
Comment on attachment 375516 [details] [diff] [review]
patch

There is no upstream, that's one of the points of qcms :)
Target Milestone: --- → mozilla1.9.2a1
Attachment #375516 - Flags: superreview?(pavlov)
Comment on attachment 375516 [details] [diff] [review]
patch

This doesn't need superreview. I'll try to check something like this in eventually. Note: looking over this again, a lot of the types still mismatch. e.g. unsigned int instead of size_t.
(Assignee)

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/29669195ef97
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.