491226 - reference to undefined property unifinderObserver.prototype, calendar-unifinder.js Line: 102

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b5pre) Gecko/20090502 Shiretoko/3.5b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b5pre) Gecko/20090502 Calendar/1.0pre

with pref javascript.options.strict set to true, get

Warning: reference to undefined property unifinderObserver.prototype
Source File: chrome://calendar/content/calendar-unifinder.js
Line: 102


Reproducible: Always

Steps to Reproduce:
1. start sunbird in a fresh profile
2. open error console showing warnings

Actual Results:  
Warnings include 7 instances of

Warning: reference to undefined property unifinderObserver.prototype
Source File: chrome://calendar/content/calendar-unifinder.js
Line: 102


Expected Results:  
No such warning

Comment 1

[gekacheka]

Attachment: patch: pass null because unifinderObserver is a singleton with no prototype

(patch -l -p 1 -i file.patch)

unifinderObserver is a singleton and does not have a prototype.
http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-unifinder.js#97

doQueryInterface checks for null prototype.
http://mxr.mozilla.org/comm-central/source/calendar/base/src/calUtils.js#782

Therefore safe to pass null instead.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 375549 [details] [diff] [review]
patch: pass null because unifinderObserver is a singleton with no prototype

r=philipp

Comment 3

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/6f88ff1ad0ad>

-> FIXED