As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact bugzilla-admin@mozilla.org
Last Comment Bug 491241 - crash with windowless plugins when MOZ_COMPOSITED_PLUGINS is defined.
: crash with windowless plugins when MOZ_COMPOSITED_PLUGINS is defined.
Status: RESOLVED FIXED
[not needed on 191 until bug 442109 l...
: mobile
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla1.9.2a1
Assigned To: Karl Tomlinson (back Feb 1 :karlt)
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
Depends on:
Blocks: 442109
  Show dependency treegraph
 
Reported: 2009-05-03 21:28 PDT by Karl Tomlinson (back Feb 1 :karlt)
Modified: 2010-04-14 21:10 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.28 KB, patch)
2009-05-03 21:31 PDT, Karl Tomlinson (back Feb 1 :karlt)
jmuizelaar: review+
mbeltzner: approval1.9.1-
Details | Diff | Splinter Review

Description User image Karl Tomlinson (back Feb 1 :karlt) 2009-05-03 21:28:48 PDT
nsPluginInstanceOwner::Renderer::NativeDraw() gets called for windowless plugins even when MOZ_COMPOSITED_PLUGINS is defined (but the code is currently not expecting this situation).
Comment 1 User image Karl Tomlinson (back Feb 1 :karlt) 2009-05-03 21:31:14 PDT
Created attachment 375565 [details] [diff] [review]
patch

(This also resolves a signed/unsigned comparision warning in find_dest_id.)
Comment 2 User image Jeff Muizelaar [:jrmuizel] 2009-05-04 18:19:10 PDT
Comment on attachment 375565 [details] [diff] [review]
patch

Looks good to me.

I actually had a patch similar to this that I'd forgotten about. It did it with a test for 'if (mWindow->type == nsPluginWindowType_Window)' but I might even like your way better.

Later on it might make sense to make a composited plugins a different window type like 'nsPluginWindowType_Composited'
Comment 3 User image Karl Tomlinson (back Feb 1 :karlt) 2009-05-14 22:32:15 PDT
http://hg.mozilla.org/mozilla-central/rev/b5a49d9e2bd0
Comment 4 User image Karl Tomlinson (back Feb 1 :karlt) 2009-05-14 22:33:37 PDT
Comment on attachment 375565 [details] [diff] [review]
patch

AIUI Fennec uses MOZ_COMPOSITED_PLUGINS on Maemo, and so will want this fix.
Comment 5 User image Mike Beltzner [:beltzner, not reading bugmail] 2009-05-19 10:54:36 PDT
Comment on attachment 375565 [details] [diff] [review]
patch

a191=beltzner
Comment 6 User image Mike Beltzner [:beltzner, not reading bugmail] 2009-05-27 16:08:39 PDT
Comment on attachment 375565 [details] [diff] [review]
patch

Revoking approval. We're cutting back on potential churn here. We can try again for 3.5.1

Note You need to log in before you can comment on or make changes to this bug.