Closed Bug 491241 Opened 15 years ago Closed 15 years ago

crash with windowless plugins when MOZ_COMPOSITED_PLUGINS is defined.

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: karlt, Assigned: karlt)

References

Details

(Keywords: mobile, Whiteboard: [not needed on 191 until bug 442109 lands])

Attachments

(1 file)

nsPluginInstanceOwner::Renderer::NativeDraw() gets called for windowless plugins even when MOZ_COMPOSITED_PLUGINS is defined (but the code is currently not expecting this situation).
Attached patch patchSplinter Review
(This also resolves a signed/unsigned comparision warning in find_dest_id.)
Assignee: nobody → mozbugz
Attachment #375565 - Flags: review?(jmuizelaar)
Comment on attachment 375565 [details] [diff] [review]
patch

Looks good to me.

I actually had a patch similar to this that I'd forgotten about. It did it with a test for 'if (mWindow->type == nsPluginWindowType_Window)' but I might even like your way better.

Later on it might make sense to make a composited plugins a different window type like 'nsPluginWindowType_Composited'
Attachment #375565 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/mozilla-central/rev/b5a49d9e2bd0
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: wanted-fennec1.0?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 375565 [details] [diff] [review]
patch

AIUI Fennec uses MOZ_COMPOSITED_PLUGINS on Maemo, and so will want this fix.
Attachment #375565 - Flags: approval1.9.1?
Whiteboard: [needs 191 approval]
Blocks: 442109
Attachment #375565 - Flags: approval1.9.1? → approval1.9.1+
Whiteboard: [needs 191 approval] → [needs 191 landing after bug 442109]
Whiteboard: [needs 191 landing after bug 442109] → [not needed on 191 until bug 442109 lands]
Comment on attachment 375565 [details] [diff] [review]
patch

Revoking approval. We're cutting back on potential churn here. We can try again for 3.5.1
Attachment #375565 - Flags: approval1.9.1+ → approval1.9.1-
Flags: wanted-fennec1.0?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: