Closed
Bug 491241
Opened 15 years ago
Closed 15 years ago
crash with windowless plugins when MOZ_COMPOSITED_PLUGINS is defined.
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: karlt, Assigned: karlt)
References
Details
(Keywords: mobile, Whiteboard: [not needed on 191 until bug 442109 lands])
Attachments
(1 file)
6.28 KB,
patch
|
jrmuizel
:
review+
beltzner
:
approval1.9.1-
|
Details | Diff | Splinter Review |
nsPluginInstanceOwner::Renderer::NativeDraw() gets called for windowless plugins even when MOZ_COMPOSITED_PLUGINS is defined (but the code is currently not expecting this situation).
Assignee | ||
Comment 1•15 years ago
|
||
(This also resolves a signed/unsigned comparision warning in find_dest_id.)
Assignee: nobody → mozbugz
Attachment #375565 -
Flags: review?(jmuizelaar)
Comment 2•15 years ago
|
||
Comment on attachment 375565 [details] [diff] [review] patch Looks good to me. I actually had a patch similar to this that I'd forgotten about. It did it with a test for 'if (mWindow->type == nsPluginWindowType_Window)' but I might even like your way better. Later on it might make sense to make a composited plugins a different window type like 'nsPluginWindowType_Composited'
Attachment #375565 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b5a49d9e2bd0
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: wanted-fennec1.0?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 375565 [details] [diff] [review] patch AIUI Fennec uses MOZ_COMPOSITED_PLUGINS on Maemo, and so will want this fix.
Attachment #375565 -
Flags: approval1.9.1?
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs 191 approval]
Updated•15 years ago
|
Attachment #375565 -
Flags: approval1.9.1? → approval1.9.1+
Comment 5•15 years ago
|
||
Comment on attachment 375565 [details] [diff] [review] patch a191=beltzner
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs 191 approval] → [needs 191 landing after bug 442109]
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs 191 landing after bug 442109] → [not needed on 191 until bug 442109 lands]
Comment 6•15 years ago
|
||
Comment on attachment 375565 [details] [diff] [review] patch Revoking approval. We're cutting back on potential churn here. We can try again for 3.5.1
Attachment #375565 -
Flags: approval1.9.1+ → approval1.9.1-
Assignee | ||
Updated•14 years ago
|
Flags: wanted-fennec1.0?
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•