491247 - utils.js: reference to undefined property aPopup.childNodes[aPopup._startMarker + 1]

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dão Gottwald [:dao]]

JavaScript strict warning: chrome://browser/content/places/utils.js, line 1328: reference to undefined property aPopup.childNodes[aPopup._startMarker + 1]

Seen in a leak test build log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1241419248.1241419616.31584.gz

Comment 1

[martin]

I see it with a new clean profile, Firefox 3.5 RC3 - Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5

- open Firefox, or a new main window
- open the contextual menu (right-click) on a Live Bookmarks on the Bookmarks Toolbar, and choose "Reload Live Bookmark"

Warning: reference to undefined property aPopup.childNodes[aPopup._startMarker + 1]
Source File: chrome://browser/content/places/utils.js
Line: 1322

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 385725 [details] [diff] [review]
patch

So, if i read this correctly the warning is about the popup being empty, and we are trying to insert before item 0 (that does not exist at that stage).
Fine by me

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/cc43d0c05fdb

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv