Closed
Bug 491301
Opened 16 years ago
Closed 16 years ago
Create new "dark" theme
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
|
51.57 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
Pull together a new theme based on the work of Martell and Madhava.
See:
http://blog.seanmartell.com/2009/04/06/revisiting-the-fennec-default-theme/
http://mozilla.seanmartell.com/fennec/index_updated.html
The new theme is completely CSS and makes use of -moz-border-colors, which could be a performance issue. We could also use box-shadow which looks even better, but might have even worse performance results. We'll see.
| Assignee | ||
Comment 1•16 years ago
|
||
This patch updates the theme to the new "dark" theme:
* Adds new CSS for buttons, panels, dark buttons and radios to platform.css
* Adds new classes to browser.xul
* Updates (adds & removes) styles from browser.css
* Updates images and the jar.mn file
There are still things we need to do:
* Red close buttons
* Resize the sidebar widths
* Add the green/red hints to the checkboxes
* Add the pressed larry states for EV and SSL
But the current patch does a heck of a lot and we can use followup patches for the rest.
Assignee: nobody → mark.finkle
Attachment #375707 -
Flags: review?(gavin.sharp)
| Assignee | ||
Comment 2•16 years ago
|
||
Oops, forgot to mention that the current patch does not include the wince changes. I will certainly add them, but they could make reviewing the patch a pain.
Also, screen shots can be found here:
http://people.mozilla.com/~mfinkle/fennec/screenshots/
in the "fennec-dark-xx.png" files
Updated•16 years ago
|
Attachment #375707 -
Flags: review?(gavin.sharp) → review+
| Assignee | ||
Comment 3•16 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/4fb85e309287
I'll file a followup for the known work yet to land.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•