Closed
Bug 491323
Opened 16 years ago
Closed 16 years ago
clicking grippy doesn't collapse content
Categories
(Core :: XUL, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: rossi, Assigned: roc)
References
()
Details
(Keywords: regression, testcase, verified1.9.1)
Attachments
(1 file)
|
3.35 KB,
patch
|
bzbarsky
:
review+
roc
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
go to url
click the grippy
grippy changes state but no content is collapsed
|
||
Comment 1•16 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090503 Minefield/3.6a1pre
Seems like a trunk only bug for now.
Flags: blocking1.9.2?
Version: unspecified → Trunk
|
||
Comment 2•16 years ago
|
||
Regression range is: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afbfa44b8d25&tochange=f6d27eb05ec1
Sounds like caused by Bug 384037.
Blocks: 384037
Keywords: regression,
testcase
|
||
Comment 3•16 years ago
|
||
Confirmed as regression on the 1.9.1 branch. It is no longer possible to collapse the application sidebar by dragging the splitter or clicking the grippy.
Works in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090515 Calendar/1.0pre (BuildID: 20090515061411)
Fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090516 Calendar/1.0pre (BuildID: 20090516044728)
Checkins during regression range: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=c869ef44ba83&tochange=c123669c9f38
|
|
||
Updated•16 years ago
|
Flags: blocking1.9.2? → blocking1.9.1?
|
||
Comment 4•16 years ago
|
||
Hey Roc,
We either need this fixed or bug 384037 backed out on branch.
Assignee: nobody → roc
Flags: blocking1.9.1? → blocking1.9.1+
|
||
Comment 5•16 years ago
|
||
Talked to Roc on this. If it's simple, we'll patch it. If not, we'll back out. Working on it now.
|
Assignee | |
Updated•16 years ago
|
Attachment #378745 -
Flags: review? → review?(dbaron)
|
|
Assignee | |
Comment 7•16 years ago
|
||
Comment on attachment 378745 [details] [diff] [review]
fix
whichever of dbaron or bz gets to the first can review this very simple fix...
Attachment #378745 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs review]
|
|
Assignee | |
Updated•16 years ago
|
Attachment #378745 -
Flags: review+
|
|
Assignee | |
Comment 8•16 years ago
|
||
Comment on attachment 378745 [details] [diff] [review]
fix
r=shaver
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs review] → [needs landing][needs 191 landing]
|
||
Comment 9•16 years ago
|
||
Comment on attachment 378745 [details] [diff] [review]
fix
r+sr=bzbarsky. Thanks for the tests!
Attachment #378745 -
Flags: superreview+
Attachment #378745 -
Flags: review?(dbaron)
Attachment #378745 -
Flags: review?(bzbarsky)
Attachment #378745 -
Flags: review+
|
|
Assignee | |
Comment 10•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing][needs 191 landing] → [needs 191 landing]
|
|
Assignee | |
Comment 11•16 years ago
|
||
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing]
|
||
Comment 12•16 years ago
|
||
verified FIXED on builds:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre ID:20090526044156
and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090528 Shiretoko/3.5pre ID:20090528045343
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•