491323 - clicking grippy doesn't collapse content

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[rossi]

go to url
click the grippy
grippy changes state but no content is collapsed

Comment 1

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090503 Minefield/3.6a1pre

Seems like a trunk only bug for now.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression range is: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afbfa44b8d25&tochange=f6d27eb05ec1
Sounds like caused by Bug 384037.

Comment 3

[Stefan Sitter [:ssitter]]

Confirmed as regression on the 1.9.1 branch. It is no longer possible to collapse the application sidebar by dragging the splitter or clicking the grippy.

Works in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090515 Calendar/1.0pre (BuildID: 20090515061411)

Fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090516 Calendar/1.0pre (BuildID: 20090516044728)

Checkins during regression range: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=c869ef44ba83&tochange=c123669c9f38

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Hey Roc,

We either need this fixed or bug 384037 backed out on branch.

Comment 5

[Damon Sicore (:damons)]

Talked to Roc on this.  If it's simple, we'll patch it.  If not, we'll back out.  Working on it now.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is very simple indeed...

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 378745 [details] [diff] [review]
fix

whichever of dbaron or bz gets to the first can review this very simple fix...

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 378745 [details] [diff] [review]
fix

r=shaver

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 378745 [details] [diff] [review]
fix

r+sr=bzbarsky.  Thanks for the tests!

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/b656480b91ac

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7b40fc4255a6

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre ID:20090526044156

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090528 Shiretoko/3.5pre ID:20090528045343