clicking grippy doesn't collapse content

VERIFIED FIXED

Status

()

Product:
Core
Component:
XUL
Status:
VERIFIED FIXED
Reported:
10 years ago
Modified:
10 years ago

People

(Reporter: rossi, Assigned: roc)

Tracking

({regression, testcase, verified1.9.1})

Version:
Trunk
Platform:
x86
Windows XP
Keywords:
regression, testcase, verified1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

fix
3.35 KB, patch
bzbarsky
: review+
roc
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

•
10 years ago 
go to url
click the grippy
grippy changes state but no content is collapsed

Comment 1

•
10 years ago 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090503 Minefield/3.6a1pre

Seems like a trunk only bug for now.
Flags: blocking1.9.2?
Version: unspecified → Trunk

Comment 2

•
10 years ago 
Regression range is: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afbfa44b8d25&tochange=f6d27eb05ec1
Sounds like caused by Bug 384037.
Blocks: 384037
Keywords: regression, testcase

Comment 3

•
10 years ago 
Confirmed as regression on the 1.9.1 branch. It is no longer possible to collapse the application sidebar by dragging the splitter or clicking the grippy.

Works in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090515 Calendar/1.0pre (BuildID: 20090515061411)

Fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090516 Calendar/1.0pre (BuildID: 20090516044728)

Checkins during regression range: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=c869ef44ba83&tochange=c123669c9f38
Flags: blocking1.9.2? → blocking1.9.1?

Comment 4

•
10 years ago 
Hey Roc,

We either need this fixed or bug 384037 backed out on branch.
Assignee: nobody → roc
Flags: blocking1.9.1? → blocking1.9.1+

Comment 5

•
10 years ago 
Talked to Roc on this.  If it's simple, we'll patch it.  If not, we'll back out.  Working on it now.
 (Assignee)

Comment 6

•
10 years ago 
Created attachment 378745 [details] [diff] [review]
fix

This is very simple indeed...
Attachment #378745 - Flags: review?
Attachment #378745 - Flags: review? → review?(dbaron)
 (Assignee)

Comment 7

•
10 years ago 
Comment on attachment 378745 [details] [diff] [review]
fix

whichever of dbaron or bz gets to the first can review this very simple fix...
Attachment #378745 - Flags: review?(bzbarsky)
Whiteboard: [needs review]
Whiteboard: [needs review] → [needs landing][needs 191 landing]

Comment 9

•
10 years ago 
Comment on attachment 378745 [details] [diff] [review]
fix

r+sr=bzbarsky.  Thanks for the tests!
Attachment #378745 - Flags: superreview+
Attachment #378745 - Flags: review?(dbaron)
Attachment #378745 - Flags: review?(bzbarsky)
Attachment #378745 - Flags: review+
 (Assignee)

Comment 10

•
10 years ago 
http://hg.mozilla.org/mozilla-central/rev/b656480b91ac
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing][needs 191 landing] → [needs 191 landing]

Comment 12

•
10 years ago 
verified FIXED on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre ID:20090526044156

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090528 Shiretoko/3.5pre ID:20090528045343
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.