Closed Bug 491338 Opened 12 years ago Closed 12 years ago

Remove tree focus rings again

Categories

(Thunderbird :: Mail Window Front End, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
I don't like the focus rings around Thunderbird's trees: They look non-native, they create an ugly margin around the tree contents, and they're unnecessary: You can tell whether a tree has focus by looking at the highlight color of the selected row.

Moreover, it looks like there presence wasn't intended in the first place. There's already a rule to remove them, but the selector doesn't match since bug 201499 introduced the tree-stack.
Attachment #375650 - Flags: review?(philringnalda)
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #375650 - Attachment is patch: true
Attachment #375650 - Attachment mime type: application/octet-stream → text/plain
(In reply to comment #0)
> You can tell whether a tree has focus by looking at the highlight color of the
> selected row.

STR:
1. Load a folder you haven't loaded yet this session, so no message is selected.
2. Hit tab.
3. Go get a cup of coffee.
4. Focus, focus, who's got the focus?
Heh, ok. Do you think these special cases are worth it?
Comment on attachment 375650 [details] [diff] [review]
fix

On second (actually, I think I'm somewhere in the fortieths) thought, no. If we're going to have tree focus rings, we should have them on all platforms, not only on the one platform where they're least-native, and we shouldn't have them because of a broken selector, and we shouldn't have them just because every other platform has a dotted outline to show a focused but not selected tree item (which in my steps tells you just where the focus is, on Windows and Linux), and we don't.
Attachment #375650 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/6bd56c8f308e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.