491338 - Remove tree focus rings again

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix

I don't like the focus rings around Thunderbird's trees: They look non-native, they create an ugly margin around the tree contents, and they're unnecessary: You can tell whether a tree has focus by looking at the highlight color of the selected row.

Moreover, it looks like there presence wasn't intended in the first place. There's already a rule to remove them, but the selector doesn't match since bug 201499 introduced the tree-stack.

Comment 1

[Phil Ringnalda (:philor)]

(In reply to comment #0)
> You can tell whether a tree has focus by looking at the highlight color of the
> selected row.

STR:
1. Load a folder you haven't loaded yet this session, so no message is selected.
2. Hit tab.
3. Go get a cup of coffee.
4. Focus, focus, who's got the focus?

Comment 2

[Markus Stange [:mstange]]

Heh, ok. Do you think these special cases are worth it?

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 375650 [details] [diff] [review]
fix

On second (actually, I think I'm somewhere in the fortieths) thought, no. If we're going to have tree focus rings, we should have them on all platforms, not only on the one platform where they're least-native, and we shouldn't have them because of a broken selector, and we shouldn't have them just because every other platform has a dotted outline to show a focused but not selected tree item (which in my steps tells you just where the focus is, on Windows and Linux), and we don't.

Comment 4

[Markus Stange [:mstange]]

http://hg.mozilla.org/comm-central/rev/6bd56c8f308e