Identifier "id" is reserved in Objective-C and should be avoided

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.68 KB, patch
Edwin Smith
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Various local usages of "id" need to be renamed to avoid possible conflict.
(Assignee)

Comment 1

9 years ago
Created attachment 375719 [details] [diff] [review]
Patch

Corrects usages in AvmCore.cpp: "id" -> "ident"
Attachment #375719 - Flags: review?(edwsmith)

Comment 2

9 years ago
Comment on attachment 375719 [details] [diff] [review]
Patch

in the first diff hunk, renaming 'id' to 'ident' makes sense.

the remaining 'id' variables stand for 'integer double', ie a double that was converted to an int.  calling them ident is misleading.  intval or anything else sensible in context, would be fine.
Attachment #375719 - Flags: review?(edwsmith) → review-
(Assignee)

Comment 3

9 years ago
good catch. ok to push if I change the second set to "intval" or some such?
(Assignee)

Comment 4

9 years ago
Created attachment 375834 [details] [diff] [review]
Patch

updated patch with better renames.
Attachment #375719 - Attachment is obsolete: true
Attachment #375834 - Flags: review?(edwsmith)

Updated

9 years ago
Attachment #375834 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 5

9 years ago
pushed to redux as changeset:   1840:2ec02b439233
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 6

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.