Closed
Bug 491401
Opened 15 years ago
Closed 15 years ago
Identifier "id" is reserved in Objective-C and should be avoided
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file, 1 obsolete file)
|
5.68 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
Various local usages of "id" need to be renamed to avoid possible conflict.
|
Assignee | |
Comment 1•15 years ago
|
||
Corrects usages in AvmCore.cpp: "id" -> "ident"
Attachment #375719 -
Flags: review?(edwsmith)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 375719 [details] [diff] [review] Patch in the first diff hunk, renaming 'id' to 'ident' makes sense. the remaining 'id' variables stand for 'integer double', ie a double that was converted to an int. calling them ident is misleading. intval or anything else sensible in context, would be fine.
Attachment #375719 -
Flags: review?(edwsmith) → review-
|
|
Assignee | |
Comment 3•15 years ago
|
||
good catch. ok to push if I change the second set to "intval" or some such?
|
|
Assignee | |
Comment 4•15 years ago
|
||
updated patch with better renames.
Attachment #375719 -
Attachment is obsolete: true
Attachment #375834 -
Flags: review?(edwsmith)
|
|
||
Updated•15 years ago
|
Attachment #375834 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
pushed to redux as changeset: 1840:2ec02b439233
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 6•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•