491407 - Directory page for collections containing an extension

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[Justin Scott [:fligtar]]

We should have a view of the collection directory that lists the collections that contain a particular add-on that's linked to from each add-on's display page, as indicated in bug 456139. We don't need a tab or anything special for this page, it should look just like the other directory pages but with a heading of "Collections containing [Add-on name]"

Comment 1

[Wil Clouser [:clouserw]]

Moving P3s to 5.0.7 for priority reevaluation in the next milestone.

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This adds a page like: collections/addon/1865 showing all collections an add-on is contained in.

Comment 4

[Jeff Balogh (:jbalogh)]

Comment on attachment 383767 [details] [diff] [review]
Patch, rev. 1

>diff --git a/site/app/controllers/collections_controller.php b/site/app/controllers/collections_controller.php

>@@ -166,6 +168,29 @@ class CollectionsController extends AppController
>         $this->_listing($collections);
>     }
> 
>+    function addon($id) {
>+        if (!$id || !is_numeric($id)) {
>+            $this->flash(sprintf(_('error_missing_argument'), 'addon_id'), '/', 3);
>+            return;
>+        }
>+        $addon = $this->Addon->getAddon($id);
>+        $collections = $this->Collection->execute(
>+            "SELECT Collection.id
>+            FROM collections AS Collection JOIN addons_collections AS ac
>+            ON Collection.id = ac.collection_id
>+            WHERE ac.addon_id = " . $id);

You could use AddonCollection->getPopularCollectionsForAddon() instead of repeating the query.

>diff --git a/site/app/views/collections/listing.thtml b/site/app/views/collections/listing.thtml

>@@ -62,6 +66,7 @@ $this->layout = 'amo2009';
>     <?php endif; ?>
>     <div class="featured listing">
>       <div class="featured-inner">
>+        <?php if (empty($hide_listing_header)): ?>
>         <div class="listing-header">
>           <ul>
>             <?php foreach ($tabs as $tab): ?>
>@@ -75,6 +80,7 @@ $this->layout = 'amo2009';
>           </ul>
>           <?=$this->renderElement('amo2009/collections_sort_form')?>
>         </div> <!-- listing-header -->
>+        <?php endif; ?>
>         <script type="text/javascript">
>           <?=$this->renderElement('amo2009/collections_js_init')?>
>         </script>

r+ if you reindent everything in the if block.

Comment 5

[Fred Wenzel [:wenzel]]

Code: r27968, some indentation: r27969.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collections/addon/1865; from where is this linked, though?

Comment 7

[Fred Wenzel [:wenzel]]

That's a legitimate question! The link, for some reason, is bug 496442.