wrong x and width of treeitem

VERIFIED FIXED in mozilla1.9.1

Status

()

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access, fixed1.9.1})

unspecified
mozilla1.9.1
All
Windows XP
access, fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Since we don't expose tree cell accessibles in the meantime and expose tree row accessibles only then we should return coordinates and size of tree row, not of key cell of tree row.
(Assignee)

Comment 1

10 years ago
Initially MSAA's specific GetBounds has been introduced in checkin (http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/accessible/src/msaa&command=DIFF_FRAMESET&file=nsXULTreeAccessibleWrap.cpp&rev2=1.3&rev1=1.2) that is refereed to bug 286029 whose patch doesn't contain these lines. So there is no infromation this behaviour was intentional. So I think it's worth to fix it as it was suggested in bug description.
Blocks: 368875
(Assignee)

Comment 2

10 years ago
Created attachment 375781 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #375781 - Flags: review?(marco.zehe)
Attachment #375781 - Flags: review?(david.bolter)
(Assignee)

Comment 3

10 years ago
Created attachment 375796 [details] [diff] [review]
patch2

Marco, how about this one?
Attachment #375781 - Attachment is obsolete: true
Attachment #375796 - Flags: review?(marco.zehe)
Attachment #375796 - Flags: review?(david.bolter)
Attachment #375781 - Flags: review?(marco.zehe)
Attachment #375781 - Flags: review?(david.bolter)

Comment 4

10 years ago
Comment on attachment 375796 [details] [diff] [review]
patch2

This one works great, shows the selection in braille properly again. Thanks!
Attachment #375796 - Flags: review?(marco.zehe) → review+
Comment on attachment 375796 [details] [diff] [review]
patch2

>+
>+  // Get x coordinate and width from treechildren element, get y coordinate and
>+  // height from tree cell.

Why?

I don't really understand the bug description (comment #0). Can you explain?
Comment on attachment 375796 [details] [diff] [review]
patch2

OK chatted with Marco on IRC.
r=me
Attachment #375796 - Flags: review?(david.bolter) → review+

Comment 7

10 years ago
Pushed on Alexander's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/48bc5af4a275
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Comment on attachment 375796 [details] [diff] [review]
patch2

Windows-specific fix for exposing the rectangle making up a single treeview item. Primarily needed for the Thunderbird 3 message list so screen readers can see the whole rectangle that a single message item makes up.

Tested manually by both myself and the commercial screen reader vendor reporting the problem.
Attachment #375796 - Flags: approval1.9.1?

Comment 9

10 years ago
Verified fixed using the Bookmarks list in the Organize Bookmarks dialog in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090506 Minefield/3.6a1pre (.NET CLR 3.5.30729). The rect now encompasses the whole tree item, not just from the start of the text (about 30 pixels wider).
Status: RESOLVED → VERIFIED
Comment on attachment 375796 [details] [diff] [review]
patch2

a191=beltzner
Attachment #375796 - Flags: approval1.9.1? → approval1.9.1+

Comment 11

10 years ago
Pushed to m-1.9.1 on Alexander's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6bd7517be4fa
Keywords: access, fixed1.9.1

Updated

10 years ago
Target Milestone: --- → mozilla1.9.1
You need to log in before you can comment on or make changes to this bug.