491450 - wrong x and width of treeitem

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Since we don't expose tree cell accessibles in the meantime and expose tree row accessibles only then we should return coordinates and size of tree row, not of key cell of tree row.

Comment 1

[alexander :surkov (:asurkov)]

Initially MSAA's specific GetBounds has been introduced in checkin (http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/accessible/src/msaa&command=DIFF_FRAMESET&file=nsXULTreeAccessibleWrap.cpp&rev2=1.3&rev1=1.2) that is refereed to bug 286029 whose patch doesn't contain these lines. So there is no infromation this behaviour was intentional. So I think it's worth to fix it as it was suggested in bug description.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch2

Marco, how about this one?

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 375796 [details] [diff] [review]
patch2

This one works great, shows the selection in braille properly again. Thanks!

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 375796 [details] [diff] [review]
patch2

>+
>+  // Get x coordinate and width from treechildren element, get y coordinate and
>+  // height from tree cell.

Why?

I don't really understand the bug description (comment #0). Can you explain?

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 375796 [details] [diff] [review]
patch2

OK chatted with Marco on IRC.
r=me

Comment 7

[Marco Zehe (:MarcoZ)]

Pushed on Alexander's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/48bc5af4a275

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 375796 [details] [diff] [review]
patch2

Windows-specific fix for exposing the rectangle making up a single treeview item. Primarily needed for the Thunderbird 3 message list so screen readers can see the whole rectangle that a single message item makes up.

Tested manually by both myself and the commercial screen reader vendor reporting the problem.

Comment 9

[Marco Zehe (:MarcoZ)]

Verified fixed using the Bookmarks list in the Organize Bookmarks dialog in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090506 Minefield/3.6a1pre (.NET CLR 3.5.30729). The rect now encompasses the whole tree item, not just from the start of the text (about 30 pixels wider).

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 375796 [details] [diff] [review]
patch2

a191=beltzner

Comment 11

[Marco Zehe (:MarcoZ)]

Pushed to m-1.9.1 on Alexander's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6bd7517be4fa