491517 - [Extension] Can access extension preferences while not logged in

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

The extension preferences dialog can be accessed via the optionsURL button when the user isn't logged in. This is a problem because if they then try to create an auto-publisher or do something else that requires login, it will hang.

I'm thinking the easiest way to deal with this is to just remove the optionsURL.

Comment 1

[Brian King [:kinger]]

It would also be trivial to check login on startup of preferences, and either disable some UI or bail. Latter probably better, giving them an option to go and login.

Comment 2

[David McNamara [:mackers]]

(In reply to comment #1)
> It would also be trivial to check login on startup of preferences, and either
> disable some UI or bail. Latter probably better, giving them an option to go
> and login.

There is already logic in the preferences to invalidate the UI based on logged in status. It would make sense to extend this to disable auto-publisher, etc.

Comment 3

[Brian King [:kinger]]

(In reply to comment #2)
> There is already logic in the preferences to invalidate the UI based on logged
> in status. It would make sense to extend this to disable auto-publisher, etc.

Does it listen for login changes if, for example, the user logs in or out when the Prefs window is open (possible on some platforms).

Comment 4

[David McNamara [:mackers]]

(In reply to comment #3)
> Does it listen for login changes if, for example, the user logs in or out when
> the Prefs window is open (possible on some platforms).

Yes. I implemented a notification system for this. From memory I think it's called registerLoginStateChangedObserver(). The preference window utilizes this for this purpose.

Comment 5

[Justin Scott [:fligtar]]

Ok, let's do that then if it's not too hard.

Comment 6

[David McNamara [:mackers]]

Settings window now reflects logged in status by enabling/disabling all fields that are available/unavailable when the user logs in/out.

r25337

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the latest-available version of the add-ons collector: https://people.mozilla.com/~jscott/bandwagon/2009-08-11.xpi.