491521 - [Extension] Comment icon in wrong spot

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

The comment icon is meant to indicate that an add-on has comments associated with it without having to expand that add-on's listing. The icon should be visible when the extension is collapsed.

See https://bug481149.bugzilla.mozilla.org/attachment.cgi?id=365252 for example placement.

Comment 1

[Brian King [:kinger]]

So it needs to go just to the left of the 'Added' text and time?

Comment 2

[Brian King [:kinger]]

Dave,

A question re: bandwagon.xml

Is setAddon called from a collapsed add-on in the list? If so, does it have comments available in the addon passed in? Seems like not, but I just want to confirm if it should or not.

I need a way for collapsed add-ons to determine if they have comments or not.

Comment 3

[David McNamara [:mackers]]

(In reply to comment #2)

> Is setAddon called from a collapsed add-on in the list? If so, does it have
> comments available in the addon passed in? Seems like not, but I just want to
> confirm if it should or not.

The expanded add-on is no different to collapsed add-on, it just extends it to have a different layout. 

They are both initialized with the same add-on object (setAddon is called by the constructor). Containing the object variables needed for both collapsed and expanded display.

Comment 4

[Brian King [:kinger]]

(In reply to comment #3)
> The expanded add-on is no different to collapsed add-on, it just extends it to
> have a different layout. 
> 
> They are both initialized with the same add-on object (setAddon is called by
> the constructor). Containing the object variables needed for both collapsed and
> expanded display.

Right you are, but each state has different content. What was happening was that document.getAnonymousElementByAttribute(this, 'anonid', 'commentbox') in setAddon does not exist for collapsed add-ons, so code put after that line did not execute. I put the icon code before it, but also added a check for the existence of the box.

Fix checked in, revision 25338.

Comment 5

[Carsten Book [:Tomcat]]

verified