[Extension] Comment icon in wrong spot

VERIFIED FIXED in BW-M6

Status

addons.mozilla.org Graveyard
Collector Extension
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: fligtar, Assigned: kinger)

Tracking

unspecified
BW-M6

Details

(Reporter)

Description

9 years ago
The comment icon is meant to indicate that an add-on has comments associated with it without having to expand that add-on's listing. The icon should be visible when the extension is collapsed.

See https://bug481149.bugzilla.mozilla.org/attachment.cgi?id=365252 for example placement.
(Assignee)

Updated

9 years ago
Assignee: nobody → brian
(Assignee)

Comment 1

9 years ago
So it needs to go just to the left of the 'Added' text and time?
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 years ago
Dave,

A question re: bandwagon.xml

Is setAddon called from a collapsed add-on in the list? If so, does it have comments available in the addon passed in? Seems like not, but I just want to confirm if it should or not.

I need a way for collapsed add-ons to determine if they have comments or not.
(In reply to comment #2)

> Is setAddon called from a collapsed add-on in the list? If so, does it have
> comments available in the addon passed in? Seems like not, but I just want to
> confirm if it should or not.

The expanded add-on is no different to collapsed add-on, it just extends it to have a different layout. 

They are both initialized with the same add-on object (setAddon is called by the constructor). Containing the object variables needed for both collapsed and expanded display.
(Assignee)

Comment 4

9 years ago
(In reply to comment #3)
> The expanded add-on is no different to collapsed add-on, it just extends it to
> have a different layout. 
> 
> They are both initialized with the same add-on object (setAddon is called by
> the constructor). Containing the object variables needed for both collapsed and
> expanded display.

Right you are, but each state has different content. What was happening was that document.getAnonymousElementByAttribute(this, 'anonid', 'commentbox') in setAddon does not exist for collapsed add-ons, so code put after that line did not execute. I put the icon code before it, but also added a check for the existence of the box.

Fix checked in, revision 25338.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
verified
Status: RESOLVED → VERIFIED
(Reporter)

Updated

8 years ago
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.