Design should look like: foo.com wants to know your location (Learn More...) (Share Location) (Don't Share) [ ] Remember for this site so that's changing 2 strings: geolocation.shareLocation=Share Location geolocation.dontTellThem=Don't Share
Attachment #376082 - Flags: review? → review?(gavin.sharp)
I'd suggest adding a comment (a localization note) in browser/locales/en-US/chrome/browser/browser.properties that would say something to the effect of: "If you're having trouble with the word Share, please use Allow and Block in your language." The reason for this is that we don't use the verb "Share" almost anywhere in Firefox, so putting it in here requires localizers to come up with a translation of a new word, while Allow and Block are well-established in the l10n land and we use them a lot (especially in privacy-related strings, e.g. in Page Info > Permissions; also see bug 491732) Does this make sense?
Comment on attachment 376103 [details] [diff] [review] patch v.2 I think .accesskey is preferred over just appending "key". We should get an accesskey for the remember checkbox, too (R seems to work), but maybe that's best done in a trunk only followup? Not sure.
Attachment #376103 - Flags: review? → review+
I had this applied for testing, figured I'd attach it. We can take this only on trunk if the 1 extra string addition is a problem for branch.
gavin, lets do the checkbox access key in bug 491769?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 376083 [details] screenshot removing request. this bug has been fixed.
You need to log in before you can comment on or make changes to this bug.