Closed Bug 491756 Opened 15 years ago Closed 15 years ago

Clear geolocation token when "forget about this site" is called

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Gavin, Assigned: dougt)

Details

(Keywords: verified1.9.1, Whiteboard: [geo])

Attachments

(1 file, 1 obsolete file)

patch v.2
998 bytes, patch
Gavin
: review+
Details | Diff | Splinter Review 
We already clear it when clearing cookies the normal way, but should probably also clear it when clearing stuff out for a specific site.

I guess we can't easily detect when you're clearing data for the provider's domain, so perhaps we should just clear it unconditionally?

http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/src/nsPrivateBrowsingService.js#379
Flags: blocking-firefox3.5?
I guess we could potentially compare the domain against the domain of the provider pref, so maybe we should do that.
Not essential, but definitely nice to have, IMO.
Flags: wanted-firefox3.5+
Flags: blocking-firefox3.5?
Flags: blocking-firefox3.5-
Attached patch patch v.1 (obsolete) — — Splinter Review 
Assignee: nobody → doug.turner

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v.2
        — 
          — Splinter Review
      

    


  

        Attachment #376102 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c89dd108d092
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9c6b9db74904
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Whiteboard: [geo]

    
    

    
  
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090508 Shiretoko/3.5b5pre and  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090508 Shiretoko/3.5b5pre

Verified fixed on the trunk using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090508 Minefield/3.6a1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: