491874 - When mouse up during pan ends up on the title bar, painting ends

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Doug Turner (:dougt)]

During panning around, if you pan from the bottom of the screen to the top and let go on the windows mobile title bar, we do not repaint over the checkerboard.  Once in this state, we do not recover.

Comment 1

[Ben Combee (:bcombee)]

If you see checkboard, that's usually a sign that the canvas element has moved to the wrong position.  I see this sometimes with zooms.

Comment 2

[Ben Combee (:bcombee)]

From discussion on IRC, seems to be a problem with mouseout events causing panning to never stop, which doesn't allow the screen to update.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: treats a mouse out as a mouse up

This fixes this bug for me.

Comment 4

[Ben Combee (:bcombee)]

Comment on attachment 376410 [details] [diff] [review]
treats a mouse out as a mouse up

I accept this as long as you remove the "mouseover" addEventListener, since that doesn't seem to be used.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

As I understand it, the point of the InputHandler is to have generic modules plug into it.  Given that we should allow those modules to handle mouseovers.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: removes old mouse out code, keeps mouse over listener

Comment 7

[Ben Combee (:bcombee)]

I'm cool with this... I don't think performance will be hurt too much by mouseover.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/c24b8b4ade53

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre