491884 - Remove create profile build step from unittest factory

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

[1:06pm] ted: mochitest/reftest/crashtest all create their own profiles nowadays
[1:07pm] Mossop: That creates the profile for reftests and crashtests. A new profile is also created at teh start of mochitest, mochichrome and browser-chrome runs
[1:07pm] Mossop: xpcshell tests have no profiles by default
[1:07pm] ted: Mossop: reftest/crashtest make their own profile now
[1:07pm] Mossop: ted: Oh huh
[1:07pm] ted: yeah
[1:07pm] ted: if we're still running createTestingProfile...
[1:07pm] ted: we should stop

Comment 1

[Chris Cooper [:coop] (he/him)]

Ted: can we also do away with the default profile creation that happens as part of the leaktest process, specifically:

https://hg.mozilla.org/build/buildbotcustom/file/47e119d3b744/process/factory.py#l402

Comment 2

[(not currently active) Ted Mielczarek]

I'm not sure, to be honest. leaktest.py uses automation.py, and it creates its own profile:
http://mxr.mozilla.org/mozilla-central/source/build/leaktest.py.in#74

So I'm not sure why you would need that stuff. (Might just be cruft leftover from bhearsum's straight port of the leaktest stuff from tinderbox.)

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Remove unittest profile creation steps

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 377489 [details] [diff] [review]
Remove unittest profile creation steps

Sounds good!

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 377489 [details] [diff] [review]
Remove unittest profile creation steps

changeset:   288:dfbebc6a8e16

Comment 6

[Chris Cooper [:coop] (he/him)]

Attachment: Remove profile creation classes from unittest.py

Might as well get rid of the actual classes.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 377681 [details] [diff] [review]
Remove profile creation classes from unittest.py

This is fine - we need to remove the CreateProfile steps from tryserver/factories.py as well, though.

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 377681 [details] [diff] [review]
Remove profile creation classes from unittest.py

changeset:   297:26517a66a4ba