491885 - Clearing private data gives no feedback that it has done anything or been activated

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

I noticed in the 5/6 Windows Mobile and OS X builds (the latter made by me) that if I clear private data in the options panel, the data is cleared but there is no feedback that anything has occurred. The user isn't notified that data has been cleared and the "clear..." button is selected but does not depress or otherwise show that it has been activated.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I can disable the button after clearing data, although I am not sure what trigger to use that I should enable it again.

I could also display a popup alert saying "Private data has been cleared" and then fades out.

Madhava?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I thought we used to do that in Firefox: temporarily disable the button for a few seconds after it was activated if we couldn't actually detect whether there was something to clear again. I can't find the code for that, though, so maybe we stopped doing it. Maybe not an ideal solution but at least it provides feedback.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> I thought we used to do that in Firefox: temporarily disable the button for a
> few seconds after it was activated if we couldn't actually detect whether there
> was something to clear again. I can't find the code for that, though, so maybe
> we stopped doing it. Maybe not an ideal solution but at least it provides
> feedback.

Madhava - have a preference?

Comment 4

[Madhava Enros [:madhava]]

Let's do the disabling thing.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

temporarily disables the button for 5 seconds

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/7e5438345235

Comment 7

[Al Billings [:abillings - ex-MoCo]]

Verified in my 5/21/2009 build.

Comment 8

[Ed Lee :Mardak]

Curious, any reason for the id change pref-list -> prefs-list other than to make more sense? ;)

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)
> Curious, any reason for the id change pref-list -> prefs-list other than to
> make more sense? ;)

Nope. Should have probably used "preferences-list" (I don't like shorten names that much)