Closed Bug 491885 Opened 14 years ago Closed 14 years ago

Clearing private data gives no feedback that it has done anything or been activated

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: abillings, Assigned: mfinkle)

References

Details

(Keywords: uiwanted)

Attachments

(1 file)

I noticed in the 5/6 Windows Mobile and OS X builds (the latter made by me) that if I clear private data in the options panel, the data is cleared but there is no feedback that anything has occurred. The user isn't notified that data has been cleared and the "clear..." button is selected but does not depress or otherwise show that it has been activated.
I can disable the button after clearing data, although I am not sure what trigger to use that I should enable it again.

I could also display a popup alert saying "Private data has been cleared" and then fades out.

Madhava?
Keywords: uiwanted
I thought we used to do that in Firefox: temporarily disable the button for a few seconds after it was activated if we couldn't actually detect whether there was something to clear again. I can't find the code for that, though, so maybe we stopped doing it. Maybe not an ideal solution but at least it provides feedback.
(In reply to comment #2)
> I thought we used to do that in Firefox: temporarily disable the button for a
> few seconds after it was activated if we couldn't actually detect whether there
> was something to clear again. I can't find the code for that, though, so maybe
> we stopped doing it. Maybe not an ideal solution but at least it provides
> feedback.

Madhava - have a preference?
Assignee: nobody → mark.finkle
Let's do the disabling thing.
Blocks: 477628
tracking-fennec: --- → ?
Attached patch patchSplinter Review
temporarily disables the button for 5 seconds
Attachment #378612 - Flags: review?(gavin.sharp)
Attachment #378612 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mobile-browser/rev/7e5438345235
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Verified in my 5/21/2009 build.
Status: RESOLVED → VERIFIED
Curious, any reason for the id change pref-list -> prefs-list other than to make more sense? ;)
Blocks: 499010
(In reply to comment #8)
> Curious, any reason for the id change pref-list -> prefs-list other than to
> make more sense? ;)

Nope. Should have probably used "preferences-list" (I don't like shorten names that much)
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.