"What's this?" link for source license on public page should link to an answer in user FAQ, not developer FAQ

VERIFIED FIXED in 5.12.2

Status

defect
P3
normal
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: davemgarrett, Assigned: clouserw)

Tracking

unspecified
5.12.2
Dependency tree / graph
Bug Flags:
in-litmus +

Details

()

Attachments

(1 attachment)

Reporter

Description

10 years ago
The developer FAQ is presumably for developers:
https://addons.mozilla.org/en-US/firefox/pages/developer_faq
The main FAQ is presumably for users:
https://addons.mozilla.org/en-US/firefox/pages/faq

However, on the add-on public pages the "What's this?" link for the source license links to the developer FAQ even though one would expect a normal user to be clicking on this here. Since the user is coming from the public page, the answer to this "What's this?" question should be in the context of what this means to the average user, not developer.

This should instead link to a blurb in the main FAQ explaining what this means to the average user with a link to the developer FAQ bit for more detail relevant to developers. My guess is many users don't even know what a license means in this context, so a quick and simple explanation would be needed here. As-is, the information given doesn't actually tell the user "what this is".
Assignee

Updated

10 years ago
Assignee: nobody → nnguyen
Assignee

Updated

10 years ago
Severity: minor → enhancement
Priority: -- → P4
Target Milestone: --- → 5.6
Assignee

Updated

10 years ago
Assignee: nnguyen → jorge
This is going to take some redacting on my part, so I'm moving this further in the future.
Target Milestone: 5.6 → 5.8

Updated

9 years ago
Flags: in-litmus+
Target Milestone: 5.8 → 5.9
Bumping to 5.10.
Target Milestone: 5.9 → 5.10
Assignee

Comment 4

9 years ago
Comment on attachment 439363 [details] [diff] [review]
Patch V1. Added short answer in user FAQ and changed link.

I think it's fine.  My grammar spider-sense says "that make the source code" should be "which make the source code" but stephend probably knows for sure.
Attachment #439363 - Flags: review?(clouserw) → review+
The rules on "that" vs. "which" vary (English--), but generally, "which" *must* follow a comma, as part of an appositive[1].

"That bird, which fell from the sky..." vs. "The bird that fell from the sky..." (subtle difference, I know).

"That" is fine here.

[1] http://www.kentlaw.edu/academics/lrw/grinker/LwtaThat_Versus_Which.htm
You learn something every day...

Fixed, r66248.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/addon/5791/.

<h5 id="license">
            Source Code License            <a href="/en-US/firefox/pages/faq#license">
              What's this?            </a>
          </h5>
Status: RESOLVED → VERIFIED
This is not in zamboni. Reopening.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Target Milestone: 5.10 → 5.12.1
Assignee: jorge → nobody
Severity: enhancement → normal
Priority: P4 → P3
Target Milestone: 5.12.1 → 5.12.2
Assignee

Comment 9

9 years ago
(In reply to comment #8)
> This is not in zamboni. Reopening.

You did the remora one.  You want to do it in zamboni?  Otherwise assign to me
Assignee

Comment 10

9 years ago
Oh, I didn't even assign it to you.  Well then, http://github.com/jbalogh/zamboni/commit/82e323feb60de6858120d192a82a7f762f50bd75
Assignee: nobody → clouserw
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
Verified FIXED; now points to https://preview.addons.mozilla.org/en-US/firefox/faq#license
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.