491908 - "What's this?" link for source license on public page should link to an answer in user FAQ, not developer FAQ

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Dave Garrett]

The developer FAQ is presumably for developers:
https://addons.mozilla.org/en-US/firefox/pages/developer_faq
The main FAQ is presumably for users:
https://addons.mozilla.org/en-US/firefox/pages/faq

However, on the add-on public pages the "What's this?" link for the source license links to the developer FAQ even though one would expect a normal user to be clicking on this here. Since the user is coming from the public page, the answer to this "What's this?" question should be in the context of what this means to the average user, not developer.

This should instead link to a blurb in the main FAQ explaining what this means to the average user with a link to the developer FAQ bit for more detail relevant to developers. My guess is many users don't even know what a license means in this context, so a quick and simple explanation would be needed here. As-is, the information given doesn't actually tell the user "what this is".

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

This is going to take some redacting on my part, so I'm moving this further in the future.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Bumping to 5.10.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1. Added short answer in user FAQ and changed link.

I think this works.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 439363 [details] [diff] [review]
Patch V1. Added short answer in user FAQ and changed link.

I think it's fine.  My grammar spider-sense says "that make the source code" should be "which make the source code" but stephend probably knows for sure.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

The rules on "that" vs. "which" vary (English--), but generally, "which" *must* follow a comma, as part of an appositive[1].

"That bird, which fell from the sky..." vs. "The bird that fell from the sky..." (subtle difference, I know).

"That" is fine here.

[1] http://www.kentlaw.edu/academics/lrw/grinker/LwtaThat_Versus_Which.htm

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

You learn something every day...

Fixed, r66248.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/addon/5791/.

<h5 id="license">
            Source Code License            <a href="/en-US/firefox/pages/faq#license">
              What's this?            </a>
          </h5>

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

This is not in zamboni. Reopening.

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> This is not in zamboni. Reopening.

You did the remora one.  You want to do it in zamboni?  Otherwise assign to me

Comment 10

[Wil Clouser [:clouserw]]

Oh, I didn't even assign it to you.  Well then, http://github.com/jbalogh/zamboni/commit/82e323feb60de6858120d192a82a7f762f50bd75

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; now points to https://preview.addons.mozilla.org/en-US/firefox/faq#license